-
Notifications
You must be signed in to change notification settings - Fork 2.8k
feat(gateway) add support for gateway api experimental ListenerSet #5972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat(gateway) add support for gateway api experimental ListenerSet #5972
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
|
|
Welcome @bmhughes! |
|
Hi @bmhughes. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| - When [experimental](#gateway-experimental-support) support is enabled the Gateway is expanded from | ||
| the `parentRef` of the `XListenerSet`. | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you please also complete the example just below accordingly?
|
/ok-to-test |
Pull Request Test Coverage Report for Build 20059296334Details
💛 - Coveralls |
3c418fb to
40b93de
Compare
What does it do ?
Support the use of ListenerSetswith Gateway API.
Motivation
Using Gateway API and TLS without ListenerSets requires either wildcard certs or all hosts to be known when creating the gateway, ListenerSets removes with requirement but external-dns does not support them currently.
More