Use pointer to a bool instead of bool

Author: vishesh92

api/v1beta3/cloudstackcluster_types.go

@@ -37,7 +37,7 @@ type CloudStackClusterSpec struct {
 
 	// SyncWithACS determines if an externalManaged CKS cluster should be created on ACS.
 	// +optional
-	SyncWithACS bool `json:"syncWithACS,omitempty"`
+	SyncWithACS *bool `json:"syncWithACS,omitempty"`
 }
 
 // The status of the CloudStackCluster object.

api/v1beta3/zz_generated.deepcopy.go

@@ -69,7 +69,7 @@ func (reconciler *CksClusterReconciler) Reconcile(ctx context.Context, req ctrl.
 
 // Reconcile actually reconciles the CloudStackCluster.
 func (r *CksClusterReconciliationRunner) Reconcile() (res ctrl.Result, reterr error) {
-	if !r.CSCluster.Spec.SyncWithACS || len(r.FailureDomains.Items) == 0 {
+	if r.CSCluster.Spec.SyncWithACS == nil || !*r.CSCluster.Spec.SyncWithACS || len(r.FailureDomains.Items) == 0 {
 		return ctrl.Result{}, nil
 	}
 	// Prevent premature deletion.

controllers/cks_cluster_controller.go

@@ -69,7 +69,7 @@ func (reconciler *CksMachineReconciler) Reconcile(ctx context.Context, req ctrl.
 
 // Reconcile actually reconciles the CloudStackMachine.
 func (r *CksMachineReconciliationRunner) Reconcile() (res ctrl.Result, reterr error) {
-	if !r.CSCluster.Spec.SyncWithACS {
+	if r.CSCluster.Spec.SyncWithACS == nil || !*r.CSCluster.Spec.SyncWithACS {
 		return ctrl.Result{}, nil
 	}
 	if r.CSCluster.Status.CloudStackClusterID == "" {

controllers/cks_machine_controller.go

@@ -21,6 +21,7 @@ import (
 	. "github.com/onsi/ginkgo/v2"
 	. "github.com/onsi/gomega"
 	"k8s.io/apimachinery/pkg/api/errors"
+	"k8s.io/utils/pointer"
 	infrav1 "sigs.k8s.io/cluster-api-provider-cloudstack/api/v1beta3"
 	"sigs.k8s.io/cluster-api-provider-cloudstack/controllers"
 	dummies "sigs.k8s.io/cluster-api-provider-cloudstack/test/dummies/v1beta3"
@@ -33,7 +34,7 @@ var _ = Describe("CksCloudStackMachineReconciler", func() {
 	Context("With machine controller running.", func() {
 		BeforeEach(func() {
 			dummies.SetDummyVars()
-			dummies.CSCluster.Spec.SyncWithACS = true
+			dummies.CSCluster.Spec.SyncWithACS = pointer.Bool(true)
 			dummies.CSCluster.Spec.FailureDomains = dummies.CSCluster.Spec.FailureDomains[:1]
 			dummies.CSCluster.Spec.FailureDomains[0].Name = dummies.CSFailureDomain1.Spec.Name
 			dummies.CSCluster.Status.CloudStackClusterID = "cluster-id-123"

controllers/cks_machine_controller_test.go

@@ -80,7 +80,7 @@ var ( // Declare exported dummy vars.
 	LBRuleID                string
 	PublicIPID              string
 	EndPointHost            string
-	SyncWithACS             bool
+	SyncWithACS             *bool
 	EndPointPort            int32
 	CSConf                  *simpleyaml.Yaml
 	DiskOffering            infrav1.CloudStackResourceDiskOffering
@@ -274,7 +274,7 @@ func SetDummyCAPCClusterVars() {
 	CSClusterKind = "CloudStackCluster"
 	ClusterName = "test-cluster"
 	EndPointHost = "EndpointHost"
-	SyncWithACS = true
+	SyncWithACS := pointer.Bool(true)
 	EndPointPort = int32(5309)
 	PublicIPID = "FakePublicIPID"
 	ClusterNameSpace = "default"