[release-1.27] 🐞 fix: shasum in blobfuse-proxy installer for Flatcar, fix PATH in blobfuse-proxy.service #2221
+19
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The blobfuse-proxy installer script used with Flatcar,
install-proxy-rhcos.sh, uses sha256sum to check whether blobfuse
binaries need to be (re-installed). If the checksum of blobfuse2 on the
host and blobfuse2 shipped with the container differ, the host blobfuse2
is replaced.
However, for Flatcar, we use a custom name for the blobfuse2 binary on
the host ("blobfuse2.bin") and ship a wrapper script named "blobfuse2"
to update the linker path for blobfuse2. The shasum check did not
account for this and inadvertently generated a checksum for the wrapper
script instead of the actual binary.
This change fixes that.
Signed-off-by: Thilo Fromm <thilofromm@microsoft.com>
Commit 0f30780 corrected setting a custom PATH environment in blobfuse-proxy.service. However, the change also included a bug leading to the updated PATH never actually being added to blobfuse-proxy.service. This commit fixes that. Signed-off-by: Thilo Fromm <thilofromm@microsoft.com>
k8s-ci-robot
added
the
cncf-cla: yes
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: k8s-infra-cherrypick-robot The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/M
andyzhangx
merged commit b88365b
into
kubernetes-sigs:release-1.27
20 of 22 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #2216
/assign andyzhangx