From a0cc5a868d869dd05a31469d4617717c8604e65b Mon Sep 17 00:00:00 2001 From: Taras Postument Date: Tue, 2 Dec 2025 12:54:21 +0000 Subject: [PATCH 1/4] Add dummy object selector to tests --- helm/aws-load-balancer-controller/test.yaml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/helm/aws-load-balancer-controller/test.yaml b/helm/aws-load-balancer-controller/test.yaml index a4305179a..68ce56209 100644 --- a/helm/aws-load-balancer-controller/test.yaml +++ b/helm/aws-load-balancer-controller/test.yaml @@ -302,10 +302,10 @@ controllerConfig: # objectSelector for webhook objectSelector: matchExpressions: - # - key: - # operator: - # values: - # - + - key: key + operator: In + values: + - value matchLabels: # key: value From e594b8cf7835c62812d24d4bf72a792257f42137 Mon Sep 17 00:00:00 2001 From: Taras Postument Date: Tue, 2 Dec 2025 12:54:56 +0000 Subject: [PATCH 2/4] fix `objectSelector.matchExpressions` indent --- helm/aws-load-balancer-controller/templates/webhook.yaml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/helm/aws-load-balancer-controller/templates/webhook.yaml b/helm/aws-load-balancer-controller/templates/webhook.yaml index a7fb03b45..49bc1e9d5 100644 --- a/helm/aws-load-balancer-controller/templates/webhook.yaml +++ b/helm/aws-load-balancer-controller/templates/webhook.yaml @@ -80,10 +80,10 @@ webhooks: {{ end }} objectSelector: matchExpressions: - - key: app.kubernetes.io/name - operator: NotIn - values: - - {{ include "aws-load-balancer-controller.name" . }} + - key: app.kubernetes.io/name + operator: NotIn + values: + - {{ include "aws-load-balancer-controller.name" . }} {{- if .Values.objectSelector.matchExpressions }} {{- toYaml .Values.objectSelector.matchExpressions | nindent 4 }} {{- end }} From 0123d38686f881de58e6ddc6f1df0e41ba205d88 Mon Sep 17 00:00:00 2001 From: Taras <9948629+taraspos@users.noreply.github.com> Date: Fri, 5 Dec 2025 18:41:30 +0000 Subject: [PATCH 3/4] Comment out objectSelector in test.yaml Comment out example objectSelector configuration. --- helm/aws-load-balancer-controller/test.yaml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/helm/aws-load-balancer-controller/test.yaml b/helm/aws-load-balancer-controller/test.yaml index 68ce56209..b95c986ee 100644 --- a/helm/aws-load-balancer-controller/test.yaml +++ b/helm/aws-load-balancer-controller/test.yaml @@ -302,10 +302,10 @@ controllerConfig: # objectSelector for webhook objectSelector: matchExpressions: - - key: key - operator: In - values: - - value +# - key: +# operator: +# values: +# - matchLabels: # key: value @@ -356,4 +356,4 @@ serviceMutatorWebhookConfig: podMutatorWebhookConfig: # whether or not to fail the pod creation if the webhook fails - failurePolicy: Ignore \ No newline at end of file + failurePolicy: Ignore From d7e0144a8ed3ad4bb9b0f7f20776d1e1384d2b0e Mon Sep 17 00:00:00 2001 From: Taras <9948629+taraspos@users.noreply.github.com> Date: Fri, 5 Dec 2025 18:42:27 +0000 Subject: [PATCH 4/4] Comment out example objectSelector in test.yaml Commented out example objectSelector configuration. --- helm/aws-load-balancer-controller/test.yaml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/helm/aws-load-balancer-controller/test.yaml b/helm/aws-load-balancer-controller/test.yaml index b95c986ee..53cc84018 100644 --- a/helm/aws-load-balancer-controller/test.yaml +++ b/helm/aws-load-balancer-controller/test.yaml @@ -302,10 +302,10 @@ controllerConfig: # objectSelector for webhook objectSelector: matchExpressions: -# - key: -# operator: -# values: -# - + # - key: + # operator: + # values: + # - matchLabels: # key: value