Skip to content

Update Default Value for Chart defaultSSLPolicy because of Update TLS to version 1.2 or higher #4055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
riita10069 wants to merge 1 commit into from
Closed

Update Default Value for Chart defaultSSLPolicy because of Update TLS to version 1.2 or higher #4055

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion helm/aws-load-balancer-controller/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ tolerateNonExistentBackendService:
tolerateNonExistentBackendAction:

# defaultSSLPolicy specifies the default SSL policy to use for TLS/HTTPS listeners
defaultSSLPolicy:
defaultSSLPolicy: ELBSecurityPolicy-TLS13-1-3-2021-06
Copy link
Contributor

@guessi guessi Feb 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quoted from doc

  • The ELBSecurityPolicy-TLS13-1-2-2021-06 policy is the default security policy for HTTPS listeners created using the AWS Management Console.
  • The ELBSecurityPolicy-2016-08 policy is the default security policy for HTTPS listeners created using the AWS CLI.

Keep in mind that changing the values.yaml could be a breaking change for those who don't set values while helm install/upgrade.

FYI, default of the defaultSSLPolicy will be set via flag here,

where the default definition could be found at

Copy link
Collaborator

@zac-nixon zac-nixon Feb 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. This change is particularly dangerous. If you wish to enforce SSL policy enforcement, I would suggest a feature that sets the default at the controller level using feature flags.

Copy link
Collaborator

@shraddhabang shraddhabang Feb 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have a controller flag default-ssl-policy which customers can use to set their desired policy. The controller level default is ELBSecurityPolicy-2016-08 which aligns with our CLI behavior mentioned earlier. So I don't think this is a valid change as this could break existing customer.


# Liveness probe configuration for the controller
livenessProbe:
Expand Down
Loading