Skip to content

Commit b28f6f0

Browse files
committed
Update configmap test per 1.32.0 change in client-go
1 parent c7724b8 commit b28f6f0

File tree

1 file changed

+33
-9
lines changed

1 file changed

+33
-9
lines changed

pkg/mapper/configmap/configmap_test.go

Lines changed: 33 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,13 @@ import (
55
"testing"
66
"time"
77

8-
core_v1 "k8s.io/api/core/v1"
8+
v1 "k8s.io/api/core/v1"
99
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
1010
"k8s.io/apimachinery/pkg/watch"
1111

12-
v1 "k8s.io/client-go/kubernetes/typed/core/v1"
12+
corev1 "k8s.io/client-go/applyconfigurations/core/v1"
13+
gentype "k8s.io/client-go/gentype"
14+
typedcorev1 "k8s.io/client-go/kubernetes/typed/core/v1"
1315
"k8s.io/client-go/kubernetes/typed/core/v1/fake"
1416
k8stesting "k8s.io/client-go/testing"
1517
"sigs.k8s.io/aws-iam-authenticator/pkg/config"
@@ -45,14 +47,14 @@ func makeStore() MapStore {
4547
return ms
4648
}
4749

48-
func makeStoreWClient() (MapStore, *fake.FakeConfigMaps) {
49-
fakeConfigMaps := &fake.FakeConfigMaps{}
50-
fakeConfigMaps.Fake = &fake.FakeCoreV1{}
51-
fakeConfigMaps.Fake.Fake = &k8stesting.Fake{}
50+
func makeStoreWClient() (MapStore, *fakeConfigMaps) {
51+
fakeCore := &fake.FakeCoreV1{}
52+
fakeCore.Fake = &k8stesting.Fake{}
53+
fakeConfigMaps := newFakeConfigMaps(fakeCore, "")
5254
ms := MapStore{
5355
users: make(map[string]config.UserMapping),
5456
roles: make(map[string]config.RoleMapping),
55-
configMap: v1.ConfigMapInterface(fakeConfigMaps),
57+
configMap: typedcorev1.ConfigMapInterface(fakeConfigMaps),
5658
}
5759
return ms, fakeConfigMaps
5860
}
@@ -194,7 +196,7 @@ func TestLoadConfigMap(t *testing.T) {
194196
data["mapRoles"] = roleMapping
195197
data["mapAccounts"] = autoMappedAWSAccountsYAML
196198

197-
watcher.Add(&core_v1.ConfigMap{ObjectMeta: meta, Data: data})
199+
watcher.Add(&v1.ConfigMap{ObjectMeta: meta, Data: data})
198200

199201
time.Sleep(2 * time.Second)
200202

@@ -224,7 +226,7 @@ func TestLoadConfigMap(t *testing.T) {
224226
updateData["mapUsers"] = updatedUserMapping
225227
updateData["mapRoles"] = updatedRoleMapping
226228
updateData["mapAccounts"] = updatedAWSAccountsYAML
227-
watcher.Modify(&core_v1.ConfigMap{ObjectMeta: meta, Data: updateData})
229+
watcher.Modify(&v1.ConfigMap{ObjectMeta: meta, Data: updateData})
228230

229231
//TODO: Sync without using sleep
230232
time.Sleep(10 * time.Millisecond)
@@ -375,3 +377,25 @@ func TestBadParseMapSingleQuote(t *testing.T) {
375377
t.Fatalf("unexpected %v != %v", emptyMap, m2)
376378
}
377379
}
380+
381+
type fakeConfigMaps struct {
382+
*gentype.FakeClientWithListAndApply[*v1.ConfigMap, *v1.ConfigMapList, *corev1.ConfigMapApplyConfiguration]
383+
Fake *fake.FakeCoreV1
384+
}
385+
386+
func newFakeConfigMaps(fake *fake.FakeCoreV1, namespace string) *fakeConfigMaps {
387+
return &fakeConfigMaps{
388+
gentype.NewFakeClientWithListAndApply[*v1.ConfigMap, *v1.ConfigMapList, *corev1.ConfigMapApplyConfiguration](
389+
fake.Fake,
390+
namespace,
391+
v1.SchemeGroupVersion.WithResource("configmaps"),
392+
v1.SchemeGroupVersion.WithKind("ConfigMap"),
393+
func() *v1.ConfigMap { return &v1.ConfigMap{} },
394+
func() *v1.ConfigMapList { return &v1.ConfigMapList{} },
395+
func(dst, src *v1.ConfigMapList) { dst.ListMeta = src.ListMeta },
396+
func(list *v1.ConfigMapList) []*v1.ConfigMap { return gentype.ToPointerSlice(list.Items) },
397+
func(list *v1.ConfigMapList, items []*v1.ConfigMap) { list.Items = gentype.FromPointerSlice(items) },
398+
),
399+
fake,
400+
}
401+
}

0 commit comments

Comments
 (0)