fix: use standardized http status code

cprivitere · cprivitere · commit 829e766f1e7a · 2024-07-17T14:08:53.000-05:00
Signed-off-by: Chris Privitere &lt;23177737+cprivitere@users.noreply.github.com&gt;
diff --git a/pkg/cloud/packet/client.go b/pkg/cloud/packet/client.go
@@ -358,7 +358,7 @@ func (p *Client) EnsureNodeBGPEnabled(ctx context.Context, id string) error {
 	_, response, err := p.DevicesApi.CreateBgpSession(ctx, id).BGPSessionInput(req).Execute() //nolint:bodyclose // see https://github.com/timakin/bodyclose/issues/42
 	// if we already had one, then we can ignore the error
 	// this really should be a 409, but 422 is what is returned
-	if response != nil && response.StatusCode == 422 && strings.Contains(err.Error(), "already has session") {
+	if response != nil && response.StatusCode == http.StatusUnprocessableEntity && strings.Contains(err.Error(), "already has session") {
 		err = nil
 	}
 	return err

Original file line number	Diff line number	Diff line change
`@@ -358,7 +358,7 @@ func (p *Client) EnsureNodeBGPEnabled(ctx context.Context, id string) error {`
`358`	`358`	`_, response, err := p.DevicesApi.CreateBgpSession(ctx, id).BGPSessionInput(req).Execute() //nolint:bodyclose // see https://github.com/timakin/bodyclose/issues/42`
`359`	`359`	`// if we already had one, then we can ignore the error`
`360`	`360`	`// this really should be a 409, but 422 is what is returned`
`361`		`- if response != nil && response.StatusCode == 422 && strings.Contains(err.Error(), "already has session") {`
	`361`	`+ if response != nil && response.StatusCode == http.StatusUnprocessableEntity && strings.Contains(err.Error(), "already has session") {`
`362`	`362`	`err = nil`
`363`	`363`	`}`
`364`	`364`	`return err`