Apply suggestions from code review

cprivitere · displague · web-flow · commit 53f1647e674c · 2024-06-17T16:59:22.000-05:00
Co-authored-by: Marques Johansson &lt;mjohansson@equinix.com&gt;
diff --git a/internal/emlb/emlb.go b/internal/emlb/emlb.go
@@ -255,10 +255,9 @@ func (e *EMLB) DeleteLoadBalancer(ctx context.Context, clusterScope *scope.Clust
 			return nil
 		}
 		log.Error(err, "LB Delete Failed", "EMLB ID", lbID, "Response Body", resp.Body)
-		return err
 	}
 
-	return nil
+	return err
 }
 
 // DeleteLoadBalancerOrigin deletes the Equinix Metal Load Balancer associated with a given ClusterScope.
@@ -282,10 +281,9 @@ func (e *EMLB) DeleteLoadBalancerOrigin(ctx context.Context, machineScope *scope
 			return nil
 		}
 		log.Error(err, "LB Pool Delete Failed", "Pool ID", lbPoolID, "Response Body", resp.Body)
-		return err
 	}
 
-	return nil
+	return err
 }
 
 // getLoadBalancer Returns a Load Balancer object given an id.

Original file line number	Diff line number	Diff line change
`@@ -255,10 +255,9 @@ func (e EMLB) DeleteLoadBalancer(ctx context.Context, clusterScope scope.Clust`
`255`	`255`	`return nil`
`256`	`256`	`}`
`257`	`257`	`log.Error(err, "LB Delete Failed", "EMLB ID", lbID, "Response Body", resp.Body)`
`258`		`- return err`
`259`	`258`	`}`
`260`	`259`
`261`		`- return nil`
	`260`	`+ return err`
`262`	`261`	`}`
`263`	`262`
`264`	`263`	`// DeleteLoadBalancerOrigin deletes the Equinix Metal Load Balancer associated with a given ClusterScope.`
`@@ -282,10 +281,9 @@ func (e EMLB) DeleteLoadBalancerOrigin(ctx context.Context, machineScope scope`
`282`	`281`	`return nil`
`283`	`282`	`}`
`284`	`283`	`log.Error(err, "LB Pool Delete Failed", "Pool ID", lbPoolID, "Response Body", resp.Body)`
`285`		`- return err`
`286`	`284`	`}`
`287`	`285`
`288`		`- return nil`
	`286`	`+ return err`
`289`	`287`	`}`
`290`	`288`
`291`	`289`	`// getLoadBalancer Returns a Load Balancer object given an id.`