Skip to content

Conversation

@jwtty
Copy link
Collaborator

@jwtty jwtty commented Apr 30, 2025

Description of your changes

  1. Make updaterun stage label selector description clearer, differentiate nil and empty selector.
  2. List the name of missing selected member clusters in the error message.

Fixes #

I have:

  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

Special notes for your reviewer

@codecov
Copy link

codecov bot commented Apr 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

jwtty added 4 commits May 2, 2025 21:17
Signed-off-by: Wantong Jiang <wantjian@microsoft.com>
Signed-off-by: Wantong Jiang <wantjian@microsoft.com>
Signed-off-by: Wantong Jiang <wantjian@microsoft.com>
Signed-off-by: Wantong Jiang <wantjian@microsoft.com>
@ryanzhang-oss ryanzhang-oss merged commit bf263d1 into kubefleet-dev:main May 5, 2025
14 of 16 checks passed
@jwtty jwtty deleted the nil-selector branch May 5, 2025 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants