-
Notifications
You must be signed in to change notification settings - Fork 19
Open
Labels
bugSomething isn't workingSomething isn't working
Description
Describe the bug
In the deployment.yaml for the hub-agent Helm chart, there is a command line argument passed to a container like this:
--whitelisted-users=system:serviceaccount:fleet-system:hub-agent-sa
This looks like it should be the service account that got deployed by the Helm chart. However, the name of the service account is generated based on the name of the deployment, so that won't work.
It also looks like the namespace there is hardcoded (fleet-system) and that should come from the values.yaml and not be hardcoded.
(Am I misunderstanding what this value is doing?)
Expected behavior
My guess is that this should be:
--whitelisted-users=system:serviceaccount:{{ .Values.namespace }}:{{ include "hub-agent.fullname" . }}-sa
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working