Skip to content

Commit aa31336

Browse files
committed
revise
Signed-off-by: Wantong Jiang <wantjian@microsoft.com>
1 parent 7760d6f commit aa31336

File tree

1 file changed

+9
-8
lines changed

1 file changed

+9
-8
lines changed

apis/placement/v1beta1/clusterresourceplacement_types.go

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -822,10 +822,7 @@ type ClusterResourcePlacementStatus struct {
822822
// Each snapshot has a different resource index.
823823
// One resource snapshot can contain multiple clusterResourceSnapshots CRs in order to store large amount of resources.
824824
// To get clusterResourceSnapshot of a given resource index, use the following command:
825-
// `kubectl get ClusterResourceSnapshot --selector=kubernetes-fleet.io/resource-index=$ObservedResourceIndex `
826-
// ObservedResourceIndex is the resource index that the conditions in the ClusterResourcePlacementStatus observe.
827-
// For example, a condition of `ClusterResourcePlacementWorkSynchronized` type
828-
// is observing the synchronization status of the resource snapshot with the resource index $ObservedResourceIndex.
825+
// `kubectl get ClusterResourceSnapshot --selector=kubernetes-fleet.io/resource-index=$ObservedResourceIndex`
829826
// If the rollout strategy type is `RollingUpdate`, `ObservedResourceIndex` is the default-latest resource snapshot index.
830827
// If the rollout strategy type is `External`, rollout and version control are managed by an external controller,
831828
// and this field is not empty only if all targeted clusters observe the same resource index in `PlacementStatuses`.
@@ -847,6 +844,11 @@ type ClusterResourcePlacementStatus struct {
847844
// +listMapKey=type
848845

849846
// Conditions is an array of current observed conditions for ClusterResourcePlacement.
847+
// All conditions except `ClusterResourcePlacementScheduled` correspond to the resource snapshot at the index specified by `ObservedResourceIndex`.
848+
// For example, a condition of `ClusterResourcePlacementWorkSynchronized` type
849+
// is observing the synchronization status of the resource snapshot with index `ObservedResourceIndex`.
850+
// If the rollout strategy type is `External`, and `ObservedResourceIndex` is unset due to clusters reporting different resource indices,
851+
// conditions except `ClusterResourcePlacementScheduled` will be empty or set to Unknown.
850852
// +kubebuilder:validation:Optional
851853
Conditions []metav1.Condition `json:"conditions,omitempty"`
852854
}
@@ -963,10 +965,9 @@ type ResourcePlacementStatus struct {
963965
// +kubebuilder:validation:Optional
964966
ObservedResourceIndex string `json:"observedResourceIndex,omitempty"`
965967

966-
// Conditions is an array of current observed conditions for ResourcePlacementStatus.
967-
// Each condition corresponds to the resource at the index specified by `ObservedResourceIndex`.
968-
// For example, if the RolloutStarted condition is true,
969-
// it refers to the resource currently indicated by `ObservedResourceIndex` is being rolled out.
968+
// Conditions is an array of current observed conditions on the cluster.
969+
// Each condition corresponds to the resource snapshot at the index specified by `ObservedResourceIndex`.
970+
// For example, the condition of type `RolloutStarted` is observing the rollout status of the resource snapshot with index `ObservedResourceIndex`.
970971
// +kubebuilder:validation:Optional
971972
Conditions []metav1.Condition `json:"conditions,omitempty"`
972973
}

0 commit comments

Comments
 (0)