minor fixes

Signed-off-by: Britania Rodriguez Reyes <britaniar@microsoft.com>

Author: britaniar

pkg/controllers/workapplier/controller.go

@@ -561,11 +561,6 @@ func (r *Reconciler) ensureAppliedWork(ctx context.Context, work *fleetv1beta1.W
 			return nil, controller.NewAPIServerError(false, err)
 		}
 	}
-
-	if err := r.spokeClient.Get(ctx, types.NamespacedName{Name: workRef.Name}, appliedWork); err != nil {
-		klog.ErrorS(err, "Failed to get the appliedWork", "appliedWork", appliedWork.Name)
-		return nil, controller.NewAPIServerError(false, err)
-	}
 	klog.InfoS("Recreated the appliedWork resource", "appliedWork", workRef.Name)
 	return appliedWork, nil
 }

test/e2e/placement_ro_test.go

@@ -199,7 +199,7 @@ var _ = Context("creating resourceOverride (selecting all clusters) to override
 	})
 })
 
-var _ = Context("creating resourceOverride with multiple jsonPatchOverrides to override configMap", Ordered, func() {
+var _ = FContext("creating resourceOverride with multiple jsonPatchOverrides to override configMap", Ordered, func() {
 	crpName := fmt.Sprintf(crpNameTemplate, GinkgoParallelProcess())
 	roName := fmt.Sprintf(roNameTemplate, GinkgoParallelProcess())
 	roNamespace := fmt.Sprintf(workNamespaceNameTemplate, GinkgoParallelProcess())

test/e2e/utils_test.go

@@ -954,34 +954,6 @@ func ensureCRPDisruptionBudgetDeleted(crpDisruptionBudgetName string) {
 	Eventually(removedActual, eventuallyDuration, eventuallyInterval).Should(Succeed(), "CRP disruption budget still exists")
 }
 
-func removeOtherOwner(cluster *framework.Cluster) {
-	ns := appNamespace()
-	otherOwner := metav1.OwnerReference{
-		APIVersion: "another-api-version",
-		Kind:       "another-kind",
-		Name:       "another-owner",
-		UID:        "another-uid",
-	}
-
-	Eventually(func() error {
-		if err := cluster.KubeClient.Get(ctx, types.NamespacedName{Name: ns.Name}, &ns); err != nil {
-			return err
-		}
-		// Filter out the owner reference you want to remove
-		newOwnerRefs := []metav1.OwnerReference{}
-		for _, ref := range ns.OwnerReferences {
-			if ref.Name != otherOwner.Name {
-				newOwnerRefs = append(newOwnerRefs, ref)
-			} else if ref.Name == otherOwner.Name {
-				By(fmt.Sprintf("Removing owner reference %s from namespace %s", otherOwner.Name, ns.Name))
-			}
-		}
-
-		ns.SetOwnerReferences(newOwnerRefs)
-		return cluster.KubeClient.Update(ctx, &ns)
-	}, eventuallyDuration, eventuallyInterval).Should(Succeed(), "Failed to remove other owner from namespace %s", ns.Name)
-}
-
 // verifyWorkPropagationAndMarkAsAvailable verifies that works derived from a specific CPR have been created
 // for a specific cluster, and marks these works in the specific member cluster's
 // reserved namespace as applied and available.