refactor, update tests and UX for crp status

keep available/applied condition true and update CRP status message/reason

Signed-off-by: Britania Rodriguez Reyes <britaniar@microsoft.com>

Author: britaniar

pkg/controllers/clusterresourceplacement/controller_integration_test.go

@@ -249,7 +249,7 @@ func updateClusterResourceBindingWithAvailable(binding *placementv1beta1.Cluster
 	cond = metav1.Condition{
 		Status:             metav1.ConditionTrue,
 		Type:               string(placementv1beta1.ResourceBindingAvailable),
-		Reason:             condition.AvailableReason,
+		Reason:             condition.NoResourcesSelectedReason,
 		ObservedGeneration: binding.Generation,
 	}
 	meta.SetStatusCondition(&binding.Status.Conditions, cond)
@@ -1338,7 +1338,7 @@ var _ = Describe("Test ClusterResourcePlacement Controller", func() {
 			wantCondition = metav1.Condition{
 				Status: metav1.ConditionTrue,
 				Type:   string(placementv1beta1.ClusterResourcePlacementAvailableConditionType),
-				Reason: condition.AvailableReason,
+				Reason: condition.NoResourcesSelectedReason,
 			}
 			meta.SetStatusCondition(&wantCRP.Status.Conditions, wantCondition)
 			wantCondition.Type = string(placementv1beta1.ResourceBindingAvailable)

pkg/controllers/clusterresourceplacement/placement_status.go

@@ -237,7 +237,8 @@ func setCRPConditions(
 		default:
 			// All the conditions of the given type are True.
 			cond := i.TrueClusterResourcePlacementCondition(crp.Generation, rpsSetCondTypeCounter[i][condition.TrueConditionStatus])
-			if i == condition.OverriddenCondition {
+			switch i {
+			case condition.OverriddenCondition:
 				hasOverride := false
 				for _, status := range allRPS {
 					if len(status.ApplicableResourceOverrides) > 0 || len(status.ApplicableClusterResourceOverrides) > 0 {
@@ -249,6 +250,15 @@ func setCRPConditions(
 					cond.Reason = condition.OverrideNotSpecifiedReason
 					cond.Message = "No override rules are configured for the selected resources"
 				}
+			case condition.AppliedCondition:
+				if len(crp.Status.SelectedResources) == 0 {
+					cond.Message = "Previous resources are deleted. No new resources are selected for the placement"
+				}
+			case condition.AvailableCondition:
+				if len(crp.Status.SelectedResources) == 0 {
+					cond.Reason = condition.NoResourcesSelectedReason
+					cond.Message = "No new resources are selected for the placement. Please update crp to select new resources"
+				}
 			}
 			crp.SetConditions(cond)
 		}