Tests for IsValidCamera function.

Author: kovacsv

Sources/EngineTest/CameraTest.cpp

@@ -0,0 +1,23 @@
+#include "SimpleTest.hpp"
+#include "Camera.hpp"
+
+using namespace Modeler;
+
+namespace CameraTest
+{
+
+TEST (IsValidCameraTest)
+{
+	ASSERT (IsValidCamera (glm::dvec3 (3.0, 2.0, 1.0), glm::dvec3 (0.0, 0.0, 0.0), glm::dvec3 (0.0, 0.0, 1.0), 45.0, 0.1, 100.0));
+	ASSERT (!IsValidCamera (glm::dvec3 (0.0, 0.0, 0.0), glm::dvec3 (0.0, 0.0, 0.0), glm::dvec3 (0.0, 0.0, 1.0), 45.0, 0.1, 100.0));
+	ASSERT (!IsValidCamera (glm::dvec3 (3.0, 2.0, 1.0), glm::dvec3 (0.0, 0.0, 0.0), glm::dvec3 (0.0, 0.0, 0.0), 45.0, 0.1, 100.0));
+	ASSERT (!IsValidCamera (glm::dvec3 (0.0, 0.0, 1.0), glm::dvec3 (0.0, 0.0, 0.0), glm::dvec3 (0.0, 0.0, 1.0), 45.0, 0.1, 100.0));
+	ASSERT (!IsValidCamera (glm::dvec3 (0.0, 0.0, -1.0), glm::dvec3 (0.0, 0.0, 0.0), glm::dvec3 (0.0, 0.0, 1.0), 45.0, 0.1, 100.0));
+	ASSERT (!IsValidCamera (glm::dvec3 (3.0, 2.0, 1.0), glm::dvec3 (0.0, 0.0, 0.0), glm::dvec3 (0.0, 0.0, 1.0), -45.0, 0.1, 100.0));
+	ASSERT (!IsValidCamera (glm::dvec3 (3.0, 2.0, 1.0), glm::dvec3 (0.0, 0.0, 0.0), glm::dvec3 (0.0, 0.0, 1.0), 0.0, 0.1, 100.0));
+	ASSERT (!IsValidCamera (glm::dvec3 (3.0, 2.0, 1.0), glm::dvec3 (0.0, 0.0, 0.0), glm::dvec3 (0.0, 0.0, 1.0), 45.0, -0.1, 100.0));
+	ASSERT (!IsValidCamera (glm::dvec3 (3.0, 2.0, 1.0), glm::dvec3 (0.0, 0.0, 0.0), glm::dvec3 (0.0, 0.0, 1.0), 45.0, 0.1, -100.0));
+	ASSERT (!IsValidCamera (glm::dvec3 (3.0, 2.0, 1.0), glm::dvec3 (0.0, 0.0, 0.0), glm::dvec3 (0.0, 0.0, 1.0), 45.0, 100.0, 10.0));
+}
+
+}

Sources/Modeler/Camera.cpp

@@ -163,7 +163,11 @@ bool IsValidCamera (const glm::dvec3& eye,
 		return false;
 	}
 
-	if (Geometry::IsZero (fieldOfViewY)) {
+	if (!Geometry::IsPositive (fieldOfViewY)) {
+		return false;
+	}
+
+	if (!Geometry::IsPositive (nearPlane) || !Geometry::IsPositive (farPlane)) {
 		return false;
 	}