From 05518e81115ef236d7e684f0cc79b8ed4c44bd20 Mon Sep 17 00:00:00 2001 From: Tyler Baur Date: Mon, 24 May 2021 10:57:27 -0500 Subject: [PATCH 1/2] Change `request_iteration_count` to use a get request --- lastpass/fetcher.py | 4 ++-- tests/test_fetcher.py | 16 ++++++++-------- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/lastpass/fetcher.py b/lastpass/fetcher.py index e8e33b5..a71cc12 100644 --- a/lastpass/fetcher.py +++ b/lastpass/fetcher.py @@ -50,8 +50,8 @@ def fetch(session, web_client=http): def request_iteration_count(username, web_client=http): - response = web_client.post('https://lastpass.com/iterations.php', - data={'email': username}, + response = web_client.get('https://lastpass.com/iterations.php', + params={'email': username}, headers=headers) if response.status_code != requests.codes.ok: raise NetworkError() diff --git a/tests/test_fetcher.py b/tests/test_fetcher.py index d2f716f..f1cbc39 100644 --- a/tests/test_fetcher.py +++ b/tests/test_fetcher.py @@ -58,35 +58,35 @@ def test_logout_raises_an_exception_on_HTTP_error(self): def test_request_iteration_count_makes_a_post_request(self): m = mock.Mock() - m.post.return_value = self._http_ok(str(self.key_iteration_count)) + m.get.return_value = self._http_ok(str(self.key_iteration_count)) fetcher.request_iteration_count(self.username, m) - m.post.assert_called_with('https://lastpass.com/iterations.php', - data={'email': self.username}, + m.get.assert_called_with('https://lastpass.com/iterations.php', + params={'email': self.username}, headers=fetcher.headers) def test_request_iteration_count_returns_key_iteration_count(self): m = mock.Mock() - m.post.return_value = self._http_ok(str(self.key_iteration_count)) + m.get.return_value = self._http_ok(str(self.key_iteration_count)) self.assertEqual(fetcher.request_iteration_count(self.username, m), self.key_iteration_count) def test_request_iteration_count_raises_an_exception_on_http_error(self): m = mock.Mock() - m.post.return_value = self._http_error() + m.get.return_value = self._http_error() self.assertRaises(lastpass.NetworkError, fetcher.request_iteration_count, self.username, m) def test_request_iteration_count_raises_an_exception_on_invalid_key_iteration_count(self): m = mock.Mock() - m.post.return_value = self._http_ok('not a number') + m.get.return_value = self._http_ok('not a number') self.assertRaises(lastpass.InvalidResponseError, fetcher.request_iteration_count, self.username, m) def test_request_iteration_count_raises_an_exception_on_zero_key_iteration_cont(self): m = mock.Mock() - m.post.return_value = self._http_ok('0') + m.get.return_value = self._http_ok('0') self.assertRaises(lastpass.InvalidResponseError, fetcher.request_iteration_count, self.username, m) def test_request_iteration_count_raises_an_exception_on_negative_key_iteration_cont(self): m = mock.Mock() - m.post.return_value = self._http_ok('-1') + m.get.return_value = self._http_ok('-1') self.assertRaises(lastpass.InvalidResponseError, fetcher.request_iteration_count, self.username, m) def test_request_login_makes_a_post_request(self): From 5c3ddb37be3cde9ba5bf862b06c861899441cb4d Mon Sep 17 00:00:00 2001 From: Tyler Baur Date: Tue, 25 May 2021 10:13:59 -0500 Subject: [PATCH 2/2] Update linting --- lastpass/fetcher.py | 4 ++-- tests/test_fetcher.py | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lastpass/fetcher.py b/lastpass/fetcher.py index a71cc12..da9979d 100644 --- a/lastpass/fetcher.py +++ b/lastpass/fetcher.py @@ -51,8 +51,8 @@ def fetch(session, web_client=http): def request_iteration_count(username, web_client=http): response = web_client.get('https://lastpass.com/iterations.php', - params={'email': username}, - headers=headers) + params={'email': username}, + headers=headers) if response.status_code != requests.codes.ok: raise NetworkError() diff --git a/tests/test_fetcher.py b/tests/test_fetcher.py index f1cbc39..f1c472d 100644 --- a/tests/test_fetcher.py +++ b/tests/test_fetcher.py @@ -61,8 +61,8 @@ def test_request_iteration_count_makes_a_post_request(self): m.get.return_value = self._http_ok(str(self.key_iteration_count)) fetcher.request_iteration_count(self.username, m) m.get.assert_called_with('https://lastpass.com/iterations.php', - params={'email': self.username}, - headers=fetcher.headers) + params={'email': self.username}, + headers=fetcher.headers) def test_request_iteration_count_returns_key_iteration_count(self): m = mock.Mock()