Skip to content

Commit 967da13

Browse files
authored
Merge pull request #49 from pyrmont/fix.inverted-class
Remove comments about inverted classes
2 parents 0bb7d1d + 0758a1c commit 967da13

File tree

2 files changed

+2
-10
lines changed

2 files changed

+2
-10
lines changed

Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ test: all
5050
@$(PYTHON) ./scripts/regex_test.py [^\\d]+\\s?[\\w]* $(NRAND_TESTS)
5151
@$(PYTHON) ./scripts/regex_test.py a+b*[ac]*.+.*.[\\.]. $(NRAND_TESTS)
5252
@$(PYTHON) ./scripts/regex_test.py a?b[ac*]*.?[\\]+[?]? $(NRAND_TESTS)
53-
@#python ./scripts/regex_test.py [1-5-]+[-1-2]-[-] $(NRAND_TESTS)
53+
@$(PYTHON) ./scripts/regex_test.py [1-5-]+[-1-2]-[-] $(NRAND_TESTS)
5454
@$(PYTHON) ./scripts/regex_test.py [-1-3]-[-]+ $(NRAND_TESTS)
5555
@$(PYTHON) ./scripts/regex_test.py [1-5]+[-1-2]-[\\-] $(NRAND_TESTS)
5656
@$(PYTHON) ./scripts/regex_test.py [-1-2]* $(NRAND_TESTS)
@@ -74,7 +74,7 @@ test: all
7474
@$(PYTHON) ./scripts/regex_test.py \\d $(NRAND_TESTS)
7575
@$(PYTHON) ./scripts/regex_test.py [\\d] $(NRAND_TESTS)
7676
@$(PYTHON) ./scripts/regex_test.py [^\\d] $(NRAND_TESTS)
77-
@#python ./scripts/regex_test.py [^-1-4] $(NRAND_TESTS)
77+
@$(PYTHON) ./scripts/regex_test.py [^-1-4] $(NRAND_TESTS)
7878
@echo
7979
@echo
8080
@echo

README.md

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,6 @@ Design is inspired by Rob Pike's regex-code for the book *"Beautiful Code"* [ava
77

88
Supports a subset of the syntax and semantics of the Python standard library implementation (the `re`-module).
99

10-
### Current status
11-
All supported regex-operators seem to work properly according to the test-set, with the following exception:
12-
13-
There is a problem with ranges (e.g. `[0-9]` for a digit 0-9) combined with inverted character-cases, e.g. `[^ab]` for anything but 'a' or 'b' - like `[^-0-9]` for anything not '-' or a digit 0-9. I think the code matches too broadly in that case.
14-
15-
I think you should test the patterns you are going to use. You can easily modify the test-harness to generate tests for your intended patterns to check for compliance.
16-
1710
**I will gladly accept patches correcting bugs.**
1811

1912
### Design goals
@@ -67,7 +60,6 @@ NOTE: inverted character classes are buggy - see the test harness for concrete e
6760
- `?` Question, match zero or one (non-greedy)
6861
- `[abc]` Character class, match if one of {'a', 'b', 'c'}
6962
- `[^abc]` Inverted class, match if NOT one of {'a', 'b', 'c'}
70-
**`NOTE: This feature is currently broken for some usage of character ranges!`**
7163
- `[a-zA-Z]` Character ranges, the character set of the ranges { a-z | A-Z }
7264
- `\s` Whitespace, \t \f \r \n \v and spaces
7365
- `\S` Non-whitespace

0 commit comments

Comments
 (0)