Skip to content

Commit fc42598

Browse files
Merge pull request #1990 from kili-technology/lab-4038
feat(LAB-4038): remove order when creating/updating step and isActivated
2 parents 854299d + 7de9ecf commit fc42598

File tree

4 files changed

+1
-5
lines changed

4 files changed

+1
-5
lines changed

src/kili/adapters/kili_api_gateway/project_workflow/mappers.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ def update_step_mapper(data: Union[WorkflowStepCreate, WorkflowStepUpdate]) -> d
3232
"numberOfExpectedLabelsForConsensus": data["number_of_expected_labels_for_consensus"]
3333
if "number_of_expected_labels_for_consensus" in data
3434
else None,
35-
"order": data["order"] if "order" in data else None,
3635
"stepCoverage": data["step_coverage"] if "step_coverage" in data else None,
3736
"type": data["type"] if "type" in data else None,
3837
"assignees": data["assignees"] if "assignees" in data else None,

src/kili/adapters/kili_api_gateway/project_workflow/operations.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ def get_update_project_workflow_mutation(fragment: str) -> str:
2020
id
2121
name
2222
type
23-
isActivated
2423
}
2524
}
2625
}

src/kili/adapters/kili_api_gateway/project_workflow/operations_mixin.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,4 +56,4 @@ def get_steps(
5656
f"project ID: {project_id}. The workflow v2 is not activated on this project."
5757
)
5858

59-
return [step for step in steps if step.get("isActivated") is True]
59+
return steps

src/kili/domain/project.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ class WorkflowStepCreate(TypedDict, total=False):
3232
name: Required[str]
3333
consensus_coverage: Optional[int]
3434
number_of_expected_labels_for_consensus: Optional[int]
35-
order: Required[int]
3635
step_coverage: Optional[int]
3736
type: Required[Literal["DEFAULT", "REVIEW"]]
3837
assignees: Required[list[str]]
@@ -45,7 +44,6 @@ class WorkflowStepUpdate(TypedDict, total=False):
4544
name: Optional[str]
4645
consensus_coverage: Optional[int]
4746
number_of_expected_labels_for_consensus: Optional[int]
48-
order: Optional[int]
4947
step_coverage: Optional[int]
5048
type: Optional[Literal["DEFAULT", "REVIEW"]]
5149
assignees: Optional[list[str]]

0 commit comments

Comments
 (0)