Merge pull request #1952 from kili-technology/feature/lab-3897-aau-i-can-update-project-workflow-using-the-sdk

feat(lab-3897): add default return when using update project workflow

Author: florianlega

src/kili/adapters/kili_api_gateway/project_workflow/mappers.py

@@ -2,6 +2,8 @@
 
 from typing import Dict, Union
 
+from cuid import cuid
+
 from kili.domain.project import WorkflowStepCreate, WorkflowStepUpdate
 
 from .types import ProjectWorkflowDataKiliAPIGatewayInput
@@ -26,7 +28,7 @@ def project_input_mapper(data: ProjectWorkflowDataKiliAPIGatewayInput) -> Dict:
 def update_step_mapper(data: Union[WorkflowStepCreate, WorkflowStepUpdate]) -> Dict:
     """Build the GraphQL create StepData variable to be sent in an operation."""
     step = {
-        "id": data["id"] if "id" in data else None,
+        "id": data["id"] if "id" in data else cuid(),
         "name": data["name"] if "name" in data else None,
         "consensusCoverage": data["consensus_coverage"] if "consensus_coverage" in data else None,
         "numberOfExpectedLabelsForConsensus": data["number_of_expected_labels_for_consensus"]

src/kili/adapters/kili_api_gateway/project_workflow/operations_mixin.py

@@ -28,11 +28,7 @@ def update_project_workflow(
         """Update properties in a project workflow."""
         project_workflow_input = project_input_mapper(data=project_workflow_data)
 
-        fields = tuple(
-            name
-            for name, val in project_workflow_input.items()
-            if val is not None and name != "steps"
-        )
+        fields = ["enforceStepSeparation", "steps{id}"]
         fragment = fragment_builder(fields)
         mutation = get_update_project_workflow_mutation(fragment)
 

tests/integration/presentation/test_project_workflow.py

@@ -23,7 +23,7 @@ def test_when_updating_project_workflow_then_it_returns_updated_project_workflow
 
     # Then
     kili.kili_api_gateway.graphql_client.execute.assert_called_once_with(
-        get_update_project_workflow_mutation(" enforceStepSeparation"),
+        get_update_project_workflow_mutation(" enforceStepSeparation steps{id}"),
         {
             "input": {
                 "projectId": "fake_proj_id",