chore: upgrade pylint to latest version

Author: baptiste-olivier

.pylintrc

@@ -99,10 +99,6 @@ recursive=no
 # source root.
 source-roots=
 
-# When enabled, pylint would attempt to guess common misconfiguration and emit
-# user-friendly hints instead of false-positive error messages.
-suggestion-mode=yes
-
 # Allow loading of arbitrary C extensions. Extensions are imported into the
 # active Python interpreter and may run arbitrary code.
 unsafe-load-any-extension=no
@@ -437,6 +433,7 @@ disable=raw-checker-failed,
         too-few-public-methods,
         too-many-ancestors,
         too-many-arguments,
+        too-many-positional-arguments,
         too-many-instance-attributes,
         too-many-locals,
         fixme,

pyproject.toml

@@ -71,7 +71,7 @@ dev = [
   "pymdown-extensions",
   # linting
   "pre-commit >= 3.3.0, < 4.0.0",
-  "pylint ==3.0.3",
+  "pylint == 4.0.3",
   "pyright ==1.1.347",
   # notebooks tests
   "nbformat",

src/kili/core/constants.py

@@ -19,7 +19,7 @@
     "LLM": "application/json",
 }
 
-mime_extensions_for_IV2 = {
+MIME_EXTENSIONS_FOR_IV2 = {
     "AUDIO": mime_extensions["Audio"],
     "IMAGE": mime_extensions["Image"],
     "GEOSPATIAL": mime_extensions["Geospatial"],

src/kili/core/helpers.py

@@ -16,7 +16,7 @@
 import tenacity
 
 from kili.adapters.http_client import HttpClient
-from kili.core.constants import mime_extensions_for_IV2
+from kili.core.constants import MIME_EXTENSIONS_FOR_IV2
 from kili.log.logging import logger
 
 T = TypeVar("T")
@@ -288,15 +288,15 @@ def check_file_mime_type(path: str, input_type: str, raise_error=True) -> bool:
     """Returns true if the mime type of the file corresponds to the allowed mime types of the project."""
     mime_type = get_mime_type(path.lower())
 
-    if not (mime_extensions_for_IV2[input_type] and mime_type):
+    if not (MIME_EXTENSIONS_FOR_IV2[input_type] and mime_type):
         return False
 
-    correct_mime_type = mime_type in mime_extensions_for_IV2[input_type]
+    correct_mime_type = mime_type in MIME_EXTENSIONS_FOR_IV2[input_type]
     if not correct_mime_type and raise_error:
         raise ValueError(
             f"File mime type for {path} is {mime_type} and does not correspond "
             "to the type of the project. "
-            f"File mime type should be one of {mime_extensions_for_IV2[input_type]}"
+            f"File mime type should be one of {MIME_EXTENSIONS_FOR_IV2[input_type]}"
         )
     return correct_mime_type
 

src/kili/entrypoints/cli/project/create.py

@@ -73,6 +73,7 @@ def create_project(
     if ((interface is not None) + (project_id_src is not None)) == 0:
         raise ValueError("You must use either interface argument or option --from-project")
 
+    json_interface: dict
     if interface is not None:
         with open(interface, encoding="utf-8") as interface_file:
             json_interface = json.load(interface_file)

src/kili/services/asset_import/constants.py

@@ -1,8 +1,8 @@
 """Constants for the asset_import services."""
 
-from kili.core.constants import mime_extensions_for_IV2
+from kili.core.constants import MIME_EXTENSIONS_FOR_IV2
 
-project_compatible_mimetypes = mime_extensions_for_IV2
+project_compatible_mimetypes = MIME_EXTENSIONS_FOR_IV2
 
 IMPORT_BATCH_SIZE = 100
 FRAME_IMPORT_BATCH_SIZE = 1

src/kili/use_cases/label/process_shapefiles.py

@@ -14,12 +14,12 @@
     from shapely.geometry import LinearRing, LineString, Point, Polygon
     from shapely.ops import transform
 
-SHAPELY_INSTALLED = True
+shapely_installed = True
 try:
     from shapely.geometry import LinearRing, LineString, Point, Polygon
     from shapely.ops import transform
 except ImportError:
-    SHAPELY_INSTALLED = False
+    shapely_installed = False
 
 
 def _read_shapefile_header(file_handle):
@@ -236,7 +236,7 @@ def get_json_response_from_shapefiles(
     if len(shapefile_paths) != len(job_names) or len(shapefile_paths) != len(category_names):
         raise ValueError("Shapefile paths, job names, and category names must have the same length")
 
-    if not SHAPELY_INSTALLED:
+    if not shapely_installed:
         raise ImportError("Install with `pip install kili[gis]` to use GIS features.")
 
     json_response = {}