#1898 do not launch directly into the Wireless Debugging activity on Xiaomi devices due to a bug they introduced.

Author: sds100

CHANGELOG.md

@@ -12,6 +12,7 @@
 ## Bug fixes
 
 - #1901 prompt user to set default USB configuration to 'No data transfer' after starting pro mode.
+- #1898 do not launch directly into the Wireless Debugging activity on Xiaomi devices due to a bug they introduced.
 
 ## [4.0.0 Beta 2](https://github.com/sds100/KeyMapper/releases/tag/v4.0.0-beta.02)
 

base/src/main/java/io/github/sds100/keymapper/base/promode/SystemBridgeSetupUseCase.kt

@@ -21,6 +21,7 @@ import io.github.sds100.keymapper.system.permissions.Permission
 import io.github.sds100.keymapper.system.permissions.PermissionAdapter
 import io.github.sds100.keymapper.system.root.SuAdapter
 import io.github.sds100.keymapper.system.shizuku.ShizukuAdapter
+import javax.inject.Inject
 import kotlinx.coroutines.Dispatchers
 import kotlinx.coroutines.ExperimentalCoroutinesApi
 import kotlinx.coroutines.flow.Flow
@@ -30,7 +31,6 @@ import kotlinx.coroutines.flow.flatMapLatest
 import kotlinx.coroutines.flow.flowOf
 import kotlinx.coroutines.flow.flowOn
 import kotlinx.coroutines.flow.map
-import javax.inject.Inject
 
 @RequiresApi(Constants.SYSTEM_BRIDGE_MIN_API)
 @ViewModelScoped

sysbridge/src/main/java/io/github/sds100/keymapper/sysbridge/service/SystemBridgeSetupController.kt

@@ -255,6 +255,13 @@ class SystemBridgeSetupControllerImpl @Inject constructor(
      * false then developer options was launched.
      */
     private fun launchWirelessDebuggingActivity(): Boolean {
+        // See issue #1898. Xiaomi like to do dodgy stuff, which causes a crash
+        // when long pressing the quick settings tile for wireless debugging.
+        if (Build.BRAND in setOf("xiaomi", "redmi", "poco")) {
+            highlightDeveloperOptionsWirelessDebuggingOption()
+            return false
+        }
+
         val quickSettingsIntent = Intent(TileService.ACTION_QS_TILE_PREFERENCES).apply {
             // Set the package name because this action can also resolve to a "Permission Controller" activity.
             val packageName = "com.android.settings"
@@ -280,16 +287,20 @@ class SystemBridgeSetupControllerImpl @Inject constructor(
             ctx.startActivity(quickSettingsIntent)
             return true
         } catch (_: ActivityNotFoundException) {
-            SettingsUtils.launchSettingsScreen(
-                ctx,
-                Settings.ACTION_APPLICATION_DEVELOPMENT_SETTINGS,
-                "toggle_adb_wireless",
-            )
+            highlightDeveloperOptionsWirelessDebuggingOption()
 
             return false
         }
     }
 
+    private fun highlightDeveloperOptionsWirelessDebuggingOption() {
+        SettingsUtils.launchSettingsScreen(
+            ctx,
+            Settings.ACTION_APPLICATION_DEVELOPMENT_SETTINGS,
+            "toggle_adb_wireless",
+        )
+    }
+
     fun invalidateSettings() {
         isDeveloperOptionsEnabled.update { getDeveloperOptionsEnabled() }
         isWirelessDebuggingEnabled.update { getWirelessDebuggingEnabled() }