Skip to content

Commit 7924452

Browse files
fdmananakdave
authored andcommitted
btrfs: remove fs_info argument from btrfs_reserve_metadata_bytes()
We don't need it since we can grab fs_info from the given space_info. So remove the fs_info argument. Reviewed-by: Qu Wenruo <wqu@suse.com> Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com> Reviewed-by: Anand Jain <asj@kernel.org> Signed-off-by: Filipe Manana <fdmanana@suse.com> Reviewed-by: David Sterba <dsterba@suse.com> Signed-off-by: David Sterba <dsterba@suse.com>
1 parent 6b6985a commit 7924452

File tree

6 files changed

+14
-17
lines changed

6 files changed

+14
-17
lines changed

fs/btrfs/block-rsv.c

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -218,8 +218,7 @@ int btrfs_block_rsv_add(struct btrfs_fs_info *fs_info,
218218
if (num_bytes == 0)
219219
return 0;
220220

221-
ret = btrfs_reserve_metadata_bytes(fs_info, block_rsv->space_info,
222-
num_bytes, flush);
221+
ret = btrfs_reserve_metadata_bytes(block_rsv->space_info, num_bytes, flush);
223222
if (!ret)
224223
btrfs_block_rsv_add_bytes(block_rsv, num_bytes, true);
225224

@@ -259,8 +258,7 @@ int btrfs_block_rsv_refill(struct btrfs_fs_info *fs_info,
259258
if (!ret)
260259
return 0;
261260

262-
ret = btrfs_reserve_metadata_bytes(fs_info, block_rsv->space_info,
263-
num_bytes, flush);
261+
ret = btrfs_reserve_metadata_bytes(block_rsv->space_info, num_bytes, flush);
264262
if (!ret) {
265263
btrfs_block_rsv_add_bytes(block_rsv, num_bytes, false);
266264
return 0;
@@ -530,8 +528,8 @@ struct btrfs_block_rsv *btrfs_use_block_rsv(struct btrfs_trans_handle *trans,
530528
block_rsv->type, ret);
531529
}
532530
try_reserve:
533-
ret = btrfs_reserve_metadata_bytes(fs_info, block_rsv->space_info,
534-
blocksize, BTRFS_RESERVE_NO_FLUSH);
531+
ret = btrfs_reserve_metadata_bytes(block_rsv->space_info, blocksize,
532+
BTRFS_RESERVE_NO_FLUSH);
535533
if (!ret)
536534
return block_rsv;
537535
/*
@@ -552,7 +550,7 @@ struct btrfs_block_rsv *btrfs_use_block_rsv(struct btrfs_trans_handle *trans,
552550
* one last time to force a reservation if there's enough actual space
553551
* on disk to make the reservation.
554552
*/
555-
ret = btrfs_reserve_metadata_bytes(fs_info, block_rsv->space_info, blocksize,
553+
ret = btrfs_reserve_metadata_bytes(block_rsv->space_info, blocksize,
556554
BTRFS_RESERVE_FLUSH_EMERGENCY);
557555
if (!ret)
558556
return block_rsv;

fs/btrfs/delalloc-space.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -358,8 +358,8 @@ int btrfs_delalloc_reserve_metadata(struct btrfs_inode *inode, u64 num_bytes,
358358
noflush);
359359
if (ret)
360360
return ret;
361-
ret = btrfs_reserve_metadata_bytes(fs_info, block_rsv->space_info,
362-
meta_reserve, flush);
361+
ret = btrfs_reserve_metadata_bytes(block_rsv->space_info, meta_reserve,
362+
flush);
363363
if (ret) {
364364
btrfs_qgroup_free_meta_prealloc(root, qgroup_reserve);
365365
return ret;

fs/btrfs/delayed-ref.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -228,7 +228,7 @@ int btrfs_delayed_refs_rsv_refill(struct btrfs_fs_info *fs_info,
228228
if (!num_bytes)
229229
return 0;
230230

231-
ret = btrfs_reserve_metadata_bytes(fs_info, space_info, num_bytes, flush);
231+
ret = btrfs_reserve_metadata_bytes(space_info, num_bytes, flush);
232232
if (ret)
233233
return ret;
234234

fs/btrfs/space-info.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1848,7 +1848,6 @@ static int __reserve_bytes(struct btrfs_space_info *space_info, u64 orig_bytes,
18481848
/*
18491849
* Try to reserve metadata bytes from the block_rsv's space.
18501850
*
1851-
* @fs_info: the filesystem
18521851
* @space_info: the space_info we're allocating for
18531852
* @orig_bytes: number of bytes we want
18541853
* @flush: whether or not we can flush to make our reservation
@@ -1860,15 +1859,16 @@ static int __reserve_bytes(struct btrfs_space_info *space_info, u64 orig_bytes,
18601859
* regain reservations will be made and this will fail if there is not enough
18611860
* space already.
18621861
*/
1863-
int btrfs_reserve_metadata_bytes(struct btrfs_fs_info *fs_info,
1864-
struct btrfs_space_info *space_info,
1862+
int btrfs_reserve_metadata_bytes(struct btrfs_space_info *space_info,
18651863
u64 orig_bytes,
18661864
enum btrfs_reserve_flush_enum flush)
18671865
{
18681866
int ret;
18691867

18701868
ret = __reserve_bytes(space_info, orig_bytes, flush);
18711869
if (ret == -ENOSPC) {
1870+
struct btrfs_fs_info *fs_info = space_info->fs_info;
1871+
18721872
trace_btrfs_space_reservation(fs_info, "space_info:enospc",
18731873
space_info->flags, orig_bytes, 1);
18741874

fs/btrfs/space-info.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -278,8 +278,7 @@ u64 __pure btrfs_space_info_used(const struct btrfs_space_info *s_info,
278278
void btrfs_clear_space_info_full(struct btrfs_fs_info *info);
279279
void btrfs_dump_space_info(struct btrfs_space_info *info, u64 bytes,
280280
bool dump_block_groups);
281-
int btrfs_reserve_metadata_bytes(struct btrfs_fs_info *fs_info,
282-
struct btrfs_space_info *space_info,
281+
int btrfs_reserve_metadata_bytes(struct btrfs_space_info *space_info,
283282
u64 orig_bytes,
284283
enum btrfs_reserve_flush_enum flush);
285284
void btrfs_try_granting_tickets(struct btrfs_space_info *space_info);

fs/btrfs/transaction.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -575,7 +575,7 @@ static int btrfs_reserve_trans_metadata(struct btrfs_fs_info *fs_info,
575575
* We want to reserve all the bytes we may need all at once, so we only
576576
* do 1 enospc flushing cycle per transaction start.
577577
*/
578-
ret = btrfs_reserve_metadata_bytes(fs_info, si, bytes, flush);
578+
ret = btrfs_reserve_metadata_bytes(si, bytes, flush);
579579

580580
/*
581581
* If we are an emergency flush, which can steal from the global block
@@ -585,7 +585,7 @@ static int btrfs_reserve_trans_metadata(struct btrfs_fs_info *fs_info,
585585
if (ret && flush == BTRFS_RESERVE_FLUSH_ALL_STEAL) {
586586
bytes -= *delayed_refs_bytes;
587587
*delayed_refs_bytes = 0;
588-
ret = btrfs_reserve_metadata_bytes(fs_info, si, bytes, flush);
588+
ret = btrfs_reserve_metadata_bytes(si, bytes, flush);
589589
}
590590

591591
return ret;

0 commit comments

Comments
 (0)