btrfs: update check_skip variable after unlocking current node

fdmanana · kdave · commit 25d0092a9013 · 2025-11-14T13:37:04.000+01:00
There's no need to update the local variable 'check_skip' to false inside
the critical section delimited by the lock of the current node, so do it
after unlocking the node.

Signed-off-by: Filipe Manana &lt;fdmanana@suse.com&gt;
Reviewed-by: Qu Wenruo &lt;wqu@suse.com&gt;
Signed-off-by: David Sterba &lt;dsterba@suse.com&gt;
diff --git a/fs/btrfs/ctree.c b/fs/btrfs/ctree.c
@@ -1461,8 +1461,8 @@ static noinline void unlock_up(struct btrfs_path *path, int level,
 		}
 
 		if (i >= lowest_unlock && i > skip_level) {
-			check_skip = false;
 			btrfs_tree_unlock_rw(path->nodes[i], path->locks[i]);
+			check_skip = false;
 			path->locks[i] = 0;
 			if (write_lock_level &&
 			    i > min_write_lock_level &&

Original file line number	Diff line number	Diff line change
`@@ -1461,8 +1461,8 @@ static noinline void unlock_up(struct btrfs_path *path, int level,`
`1461`	`1461`	`}`
`1462`	`1462`
`1463`	`1463`	`if (i >= lowest_unlock && i > skip_level) {`
`1464`		`- check_skip = false;`
`1465`	`1464`	`btrfs_tree_unlock_rw(path->nodes[i], path->locks[i]);`
	`1465`	`+ check_skip = false;`
`1466`	`1466`	`path->locks[i] = 0;`
`1467`	`1467`	`if (write_lock_level &&`
`1468`	`1468`	`i > min_write_lock_level &&`