Skip to content

Commit a8f8af2

Browse files
committed
Add note on commonLabels deprecation
1 parent 393da6f commit a8f8af2

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

kustomize/data_source_kustomization_overlay_test.go

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -133,6 +133,11 @@ output "check" {
133133

134134
// Test common_labels attr
135135
func TestDataSourceKustomizationOverlay_commonLabels(t *testing.T) {
136+
// Unfortunately, the controversial commonLabels deprecation
137+
// https://github.com/kubernetes-sigs/kustomize/issues/5436#issuecomment-2442056536
138+
// produces those annoying deprecation warnings. Keep the test until Kustomize
139+
// provides a well-documented alternative that everybody can switch to.
140+
// Then, after some time, we can delete the test for commonLabels.
136141

137142
resource.Test(t, resource.TestCase{
138143
IsUnitTest: true,

0 commit comments

Comments
 (0)