SonarQube cleanup - bugs cleanup

Author: karlnicholas

src/main/java/org/hdf5javalib/dataclass/reference/HdfDataspaceSelectionInstance.java

@@ -7,7 +7,7 @@
 import java.lang.reflect.InvocationTargetException;
 import java.nio.ByteBuffer;
 
-import static org.hdf5javalib.dataclass.reference.HdfDataspaceSelectionInstance.HdfSelectionType.*;
+import static org.hdf5javalib.dataclass.reference.HdfDataspaceSelectionInstance.HdfSelectionType.fromValue;
 
 public abstract class HdfDataspaceSelectionInstance {
     public abstract HdfDataHolder getData(HdfDataObject hdfDataObject, HdfDataFile hdfDataFile) throws IOException, InvocationTargetException, InstantiationException, IllegalAccessException;

src/main/java/org/hdf5javalib/datatype/ReferenceDatatype.java

@@ -2,13 +2,9 @@
 
 import org.hdf5javalib.dataclass.HdfData;
 import org.hdf5javalib.dataclass.HdfReference;
-import org.hdf5javalib.dataclass.reference.HdfAttributeReference;
-import org.hdf5javalib.dataclass.reference.HdfDatasetRegionReference;
-import org.hdf5javalib.dataclass.reference.HdfObjectReference;
-import org.hdf5javalib.dataclass.reference.HdfReferenceInstance;
+import org.hdf5javalib.dataclass.reference.*;
 import org.hdf5javalib.hdffile.infrastructure.HdfGlobalHeap;
 import org.hdf5javalib.hdfjava.HdfDataFile;
-import org.hdf5javalib.dataclass.reference.HdfDataHolder;
 
 import java.io.IOException;
 import java.lang.reflect.InvocationTargetException;

src/main/java/org/hdf5javalib/hdffile/dataobjects/HdfObjectHeaderPrefix.java

@@ -2,7 +2,6 @@
 
 import org.hdf5javalib.dataclass.HdfFixedPoint;
 import org.hdf5javalib.hdffile.dataobjects.messages.HdfMessage;
-import org.hdf5javalib.hdfjava.HdfDataFile;
 
 import java.io.IOException;
 import java.nio.ByteBuffer;

src/main/java/org/hdf5javalib/hdffile/dataobjects/HdfObjectHeaderPrefixV2.java

@@ -32,8 +32,7 @@ public HdfObjectHeaderPrefixV2(
             Integer minDenseAttributes,
             List<HdfMessage> headerMessages,
             HdfDataFile hdfDataFile,
-            long offset,
-            long prefixSize
+            long offset
     ) {
         super(headerMessages,
                 HdfWriteUtils.hdfFixedPointFromValue(offset, hdfDataFile.getSuperblock().getFixedPointDatatypeForLength()),

src/main/java/org/hdf5javalib/hdffile/dataobjects/messages/AttributeMessage.java

@@ -3,10 +3,10 @@
 import org.hdf5javalib.dataclass.HdfData;
 import org.hdf5javalib.dataclass.HdfFixedPoint;
 import org.hdf5javalib.dataclass.HdfString;
+import org.hdf5javalib.dataclass.reference.HdfDataHolder;
 import org.hdf5javalib.datatype.Datatype;
 import org.hdf5javalib.datatype.StringDatatype;
 import org.hdf5javalib.hdfjava.HdfDataFile;
-import org.hdf5javalib.dataclass.reference.HdfDataHolder;
 
 import java.io.IOException;
 import java.lang.reflect.Array;

src/main/java/org/hdf5javalib/hdffile/infrastructure/HdfLocalHeapData.java

@@ -4,8 +4,6 @@
 import org.hdf5javalib.hdfjava.HdfDataFile;
 import org.hdf5javalib.utils.HdfWriteUtils;
 
-import java.io.IOException;
-import java.nio.channels.SeekableByteChannel;
 import java.util.LinkedHashMap;
 import java.util.Map;
 

src/main/java/org/hdf5javalib/hdfjava/HdfDataset.java

@@ -13,7 +13,9 @@
 import java.nio.ByteBuffer;
 import java.nio.ByteOrder;
 import java.nio.channels.SeekableByteChannel;
-import java.util.*;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Optional;
 
 /**
  * Represents a leaf node (HdfDataset) in the B-Tree.

src/main/java/org/hdf5javalib/hdfjava/HdfFileReader.java

@@ -1133,7 +1133,7 @@ static HdfObjectHeaderPrefixV2 readV2ObjectHeader(SeekableByteChannel fileChanne
         return new HdfObjectHeaderPrefixV2(flags, sizeOfChunk0, checksum,
                 accessTime, modificationTime, changeTime, birthTime,
                 maxCompactAttributes, minDenseAttributes,
-                dataObjectHeaderMessages, hdfDataFile, objectHeaderAddress, prefixSize);
+                dataObjectHeaderMessages, hdfDataFile, objectHeaderAddress);
     }
 
     private static void parseContinuationMessages(SeekableByteChannel fileChannel, Function<ByteBuffer, HdfMessage.OBJECT_HEADER_PREFIX> prefixReader, List<HdfMessage> currentMessages, HdfDataFile hdfDataFile) throws IOException, InvocationTargetException, InstantiationException, IllegalAccessException {

src/main/java/org/hdf5javalib/utils/FlattenedArrayUtils.java

@@ -4,7 +4,6 @@
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.List;
-import java.util.Objects;
 import java.util.concurrent.atomic.AtomicInteger;
 import java.util.function.BinaryOperator;
 import java.util.function.Predicate;

src/main/java/org/hdf5javalib/utils/ScaleOffsetByteBufferDeflater.java

@@ -3,7 +3,6 @@
 import java.io.IOException;
 import java.nio.ByteBuffer;
 import java.nio.ByteOrder;
-import java.nio.IntBuffer;
 
 /**
  * An implementation of the HDF5 scale-offset filter for integer data.