Skip to content

Commit 9730b5f

Browse files
willpricejwkvam
authored andcommitted
Alpha1 (#89)
* Update dependencies * Match TS target to that of JupyterLab * Import codemirror/keymaps/vim.js JupyterLab used to load this in every time, but now they do this lazily, i.e. only when the user has selected vim mode. This breaks our plugin as it is activated prior to the vim keymap getting lazy-loaded. See the following relevant changes: - [Issue: Lazy Load Vim Mode #6511](jupyterlab/jupyterlab#6511) - [Issue: The vim key bindings in text editor doesn't work in JupyterLab 1.0.0 #6744](jupyterlab/jupyterlab#6744) - [PR: lazy load of vim mode #6516](jupyterlab/jupyterlab#6516) - [PR: Fix lazy-loading of vim mode so it doesn't race. #6786](jupyterlab/jupyterlab#6786) * Update yarn.lock * Update History.md for 0.11.0 and bump version in package.json
1 parent 763dc7f commit 9730b5f

File tree

5 files changed

+484
-447
lines changed

5 files changed

+484
-447
lines changed

History.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
# History
22

3+
## 0.11.0 / 2019-07-13
4+
5+
* Support JupyterLab 1.0.0+
6+
37
## 0.10.1 / 2018-11-21
48

59
* `ctrl i` enters Vim insert mode from Jupyter command mode (#71) Thanks @wmayner

package.json

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,11 @@
11
{
22
"name": "jupyterlab_vim",
3-
"version": "0.11.0-pre.1",
3+
"version": "0.11.0-pre.2",
44
"description": "Code cell vim bindings",
55
"author": "Jacques Kvam",
66
"license": "MIT",
77
"main": "lib/index.js",
88
"types": "lib/index.d.ts",
9-
"license": "MIT",
109
"homepage": "https://github.com/jwkvam/jupyterlab_vim",
1110
"bugs": {
1211
"url": "https://github.com/jwkvam/jupyterlab_vim/issues"
@@ -35,17 +34,17 @@
3534
"extension": true
3635
},
3736
"dependencies": {
38-
"@jupyterlab/application": "^1.0.0-alpha.6",
39-
"@jupyterlab/codemirror": "^1.0.0-alpha.6",
40-
"@jupyterlab/cells": "^1.0.0-alpha.7",
41-
"@jupyterlab/notebook": "^1.0.0-alpha.7",
42-
"@phosphor/commands": "^1.6.1",
43-
"@phosphor/coreutils": "^1.3.0",
44-
"@phosphor/domutils": "^1.1.2",
45-
"@types/codemirror": "^0.0.62"
37+
"@jupyterlab/application": "^1.0.1",
38+
"@jupyterlab/codemirror": "^1.0.1",
39+
"@jupyterlab/cells": "^1.0.1",
40+
"@jupyterlab/notebook": "^1.0.1",
41+
"@phosphor/commands": "^1.6.3",
42+
"@phosphor/coreutils": "^1.3.1",
43+
"@phosphor/domutils": "^1.1.3",
44+
"@types/codemirror": "^0.0.76"
4645
},
4746
"devDependencies": {
4847
"rimraf": "^2.6.2",
49-
"typescript": "~3.1.1"
48+
"typescript": "~3.5.1"
5049
}
5150
}

src/index.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,9 @@ import {
2525
} from '@phosphor/domutils';
2626

2727
import '../style/index.css';
28+
// Previously the vim keymap was loaded by JupyterLab, but now
29+
// it is lazy loaded, so we have to load it explicitly
30+
import 'codemirror/keymap/vim.js';
2831

2932
/**
3033
* A boolean indicating whether the platform is Mac.

tsconfig.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,9 @@
66
"skipLibCheck": true,
77
"noEmitOnError": true,
88
"noUnusedLocals": true,
9-
"lib": ["DOM", "ES6"],
109
"module": "commonjs",
1110
"moduleResolution": "node",
12-
"target": "ES6",
11+
"target": "ES2017",
1312
"outDir": "lib",
1413
"rootDir": "src",
1514
},

0 commit comments

Comments
 (0)