commit work on starting settings

Author: jwkvam

schema/plugin.json

@@ -0,0 +1,53 @@
+{
+    "jupyter.lab.setting-icon-class": "jp-NotebookIcon",
+    "jupyter.lab.setting-icon-label": "Notebook",
+    "title": "Vim Notebook Cell",
+    "description": "Vim Notebook Cell Settings",
+    "definitions": {
+        "editorConfig": {
+            "properties": {
+                "autoClosingBrackets": {
+                    "type": "boolean"
+                },
+                "lineNumbers": {
+                    "type": "boolean"
+                },
+                "lineWrap": {
+                    "type": "boolean"
+                },
+                "matchBrackets": {
+                    "type": "boolean"
+                },
+                "readOnly": {
+                    "type": "boolean"
+                },
+                "insertSpaces": {
+                    "type": "boolean"
+                },
+                "tabSize": {
+                    "type": "number"
+                }
+            },
+            "additionalProperties": false,
+            "type": "object"
+        }
+    },
+    "properties": {
+        "editorConfig": {
+            "title": "Editor Configuration",
+            "description": "The configuration for all text editors.",
+            "$ref": "#/definitions/editorConfig",
+            "default": {
+                "autoClosingBrackets": true,
+                "lineNumbers": true,
+                "lineWrap": true,
+                "matchBrackets": true,
+                "readOnly": false,
+                "insertSpaces": true,
+                "tabSize": 4
+            }
+        }
+    },
+    "additionalProperties": false,
+    "type": "object"
+}

src/index.ts

@@ -12,6 +12,10 @@ import {
     MarkdownCell
 } from '@jupyterlab/cells';
 
+import {
+  ISettingRegistry
+} from '@jupyterlab/coreutils';
+
 import {
     CodeMirrorEditor
 } from '@jupyterlab/codemirror';
@@ -29,7 +33,7 @@ const extension: JupyterLabPlugin<void> = {
   id: 'jupyterlab_vim',
   autoStart: true,
   activate: activateCellVim,
-  requires: [INotebookTracker]
+  requires: [INotebookTracker, ISettingRegistry]
 };
 
 class VimCell {
@@ -66,8 +70,7 @@ class VimCell {
             lvim.defineEx('quit', 'q', function(cm: any) {
                 commands.execute('notebook:enter-command-mode');
             });
-
-            (CodeMirror as any).Vim.handleKey(editor.editor, '<Esc>');
+            lvim.handleKey(editor.editor, '<Esc>');
             lvim.defineMotion('moveByLinesOrCell', (cm: any, head: any, motionArgs: any, vim: any) => {
                 let cur = head;
                 let endCh = cur.ch;
@@ -162,10 +165,11 @@ class VimCell {
     private _app: JupyterLab;
 }
 
-function activateCellVim(app: JupyterLab, tracker: INotebookTracker): Promise<void> {
+function activateCellVim(app: JupyterLab, tracker: INotebookTracker, settingRegistry: ISettingRegistry): Promise<void> {
+    const id = plugin.id;
+    const { commands, shell } = app;
 
-    Promise.all([app.restored]).then(([args]) => {
-        const { commands, shell } = app;
+    Promise.all([settingRegistry.load(id), app.restored]).then(([settings, args]) => {
         function getCurrent(args: ReadonlyJSONObject): NotebookPanel | null {
             const widget = tracker.currentWidget;
             const activate = args['activate'] !== false;