fix!

Author: chrisjsewell

jupyter_sphinx/ast.py

@@ -401,14 +401,8 @@ def run(self):
 
         assert filetype in ("notebook", "nb", "script")
         ext = ".ipynb" if filetype in ("notebook", "nb") else ".py"
-        output_dir = sphinx_abs_dir(self.env)
         download_file = self.target + ext
-        reftarget=os.path.realpath(os.path.join(output_dir, download_file))
-        # touch the path, so that it can be found by the download collector
-        path = pathlib.Path(self.env.srcdir).joinpath(reftarget[1:])
-        path.parent.mkdir(parents=True, exist_ok=True)
-        path.touch()
-        # make the nodes
+        reftarget = sphinx_abs_dir(self.env, download_file)
         node = download_reference(self.rawtext, reftarget=reftarget)
         self.set_source_info(node)
         title = self.title if self.has_explicit_title else download_file

jupyter_sphinx/execute.py

@@ -22,7 +22,6 @@
     default_notebook_names,
     output_directory,
     split_on,
-    sphinx_abs_dir,
     blank_nb,
 )
 from .ast import (

jupyter_sphinx/utils.py

@@ -69,14 +69,14 @@ def language_info(executor):
     return info_msg["content"]["language_info"]
 
 
-def sphinx_abs_dir(env):
+def sphinx_abs_dir(env, *paths):
     # We write the output files into
     # output_directory / jupyter_execute / path relative to source directory
     # Sphinx expects download links relative to source file or relative to
     # source dir and prepended with '/'. We use the latter option.
     return "/" + os.path.relpath(
         os.path.abspath(
-            os.path.join(output_directory(env), os.path.dirname(env.docname))
+            os.path.join(output_directory(env), os.path.dirname(env.docname), *paths)
         ),
         os.path.abspath(env.app.srcdir),
     )

tests/test_execute.py

@@ -570,9 +570,9 @@ def test_image_mimetype_uri(doctree):
 
 
 @pytest.mark.parametrize('text,reftarget,caption', (
-    ('nb_name', '/jupyter_execute/path/to/nb_name.ipynb', 'nb_name.ipynb'),
-    ('../nb_name', '/jupyter_execute/path/nb_name.ipynb', '../nb_name.ipynb'),
-    ('text <nb_name>', '/jupyter_execute/path/to/nb_name.ipynb', 'text'),
+    ('nb_name', '/../jupyter_execute/path/to/nb_name.ipynb', 'nb_name.ipynb'),
+    ('../nb_name', '/../jupyter_execute/path/nb_name.ipynb', '../nb_name.ipynb'),
+    ('text <nb_name>', '/../jupyter_execute/path/to/nb_name.ipynb', 'text'),
 ))
 def test_download_role(text, reftarget, caption, tmp_path):
     role = JupyterDownloadRole()