Merge pull request #503 from minrk/validate-return

ExtensionPoint: return True on successful validate()

Author: Zsailer

jupyter_server/extension/manager.py

@@ -129,6 +129,8 @@ def validate(self):
             self._get_loader()
         except Exception:
             return False
+        else:
+            return True
 
     def link(self, serverapp):
         """Link the extension to a Jupyter ServerApp object.

jupyter_server/extension/serverextension.py

@@ -306,7 +306,8 @@ def list_server_extensions(self):
                                 GREEN_ENABLED if enabled else RED_DISABLED))
                 try:
                     self.log.info("    - Validating {}...".format(name))
-                    extension.validate()
+                    if not extension.validate():
+                        raise ValueError("validation failed")
                     version = extension.version
                     self.log.info(
                         "      {} {} {}".format(name, version, GREEN_OK)

jupyter_server/tests/extension/test_manager.py

@@ -30,6 +30,7 @@ def test_extension_point_api():
     assert app is not None
     assert callable(e.load)
     assert callable(e.link)
+    assert e.validate()
 
 
 def test_extension_point_metadata_error():
@@ -59,6 +60,7 @@ def test_extension_package_api():
     assert hasattr(e, "extension_points")
     assert len(e.extension_points) == len(metadata_list)
     assert app.name in e.extension_points
+    assert e.validate()
 
 
 def test_extension_package_notfound_error():