Merge pull request #36 from Zsailer/notebook_dir

add notebook_dir as trait to be deprecated

Author: Zsailer

docs/source/extending/handlers.rst

@@ -115,7 +115,7 @@ following:
         Called when the extension is loaded.
 
         Args:
-            nb_server_app (NotebookWebApplication): handle to the Notebook webserver instance.
+            nb_server_app: handle to the Notebook webserver instance.
         """
         web_app = nb_server_app.web_app
         host_pattern = '.*$'

jupyter_server/serverapp.py

@@ -1124,6 +1124,16 @@ def _update_pylab(self, change):
         )
         self.exit(1)
 
+    notebook_dir = Unicode(
+        config=True,
+        help=_("DEPRECATED, use root_dir.")
+    )
+
+    @observe('notebook_dir')
+    def _update_notebook_dir(self, change):
+        self.log.warning(_("notebook_dir is deprecated, use root_dir"))
+        self.root_dir = change['new']
+
     root_dir = Unicode(config=True,
         help=_("The directory to use for notebooks and kernels.")
     )