Skip to content

Commit 54f1760

Browse files
committed
exercise put model-params
and fix config manager key
1 parent 661d48a commit 54f1760

File tree

2 files changed

+19
-1
lines changed

2 files changed

+19
-1
lines changed

jupyter_ai_jupyternaut/models/parameters_rest_api.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ def put(self):
113113
except ValueError as e:
114114
raise HTTPError(400, f"Invalid value for parameter '{param_name}': {str(e)}")
115115

116-
config_manager = self.settings.get("jai_config_manager")
116+
config_manager = self.settings.get("jupyternaut.config_manager")
117117
if not config_manager:
118118
raise HTTPError(500, "Config manager not available")
119119

jupyter_ai_jupyternaut/tests/test_handlers.py

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,3 +46,21 @@ async def test_get_parameters(jp_fetch, model):
4646
assert param in payload["parameter_names"]
4747
assert param in payload["parameters"]
4848
assert "description" in payload["parameters"][param]
49+
50+
51+
async def test_put_params(jp_fetch):
52+
# TODO: validate all types, error handling
53+
response = await jp_fetch(
54+
"api/jupyternaut/model-parameters",
55+
body=json.dumps({
56+
"model_id": "hosted_vllm/mlx-community/gpt-oss-20b-MXFP4-Q8",
57+
"parameters": {
58+
"api_base": {
59+
"value": "http://127.0.0.1:8080",
60+
"type": "string",
61+
},
62+
},
63+
}),
64+
method="PUT",
65+
)
66+
assert response.code == 200

0 commit comments

Comments
 (0)