Drop sort_if_needed

Author: juliangehring

src/pi0-estimators.jl

@@ -171,7 +171,7 @@ end
 
 function estimate(pValues::PValues{T}, pi0estimator::LeastSlope) where T <: AbstractFloat
     n = length(pValues)
-    pValues = sort_if_needed(pValues)
+    pValues = sort(pValues)
     s0 = lsl_slope(1, n, pValues)
     sx = 0
     for i in 2:n
@@ -311,7 +311,7 @@ RightBoundary() = RightBoundary([0.02:0.02:0.1; 0.15:0.05:0.95])
 
 function estimate(pValues::PValues{T}, pi0estimator::RightBoundary) where T <: AbstractFloat
     n = length(pValues)
-    λseq = sort_if_needed(pi0estimator.λseq)
+    λseq = sort(pi0estimator.λseq)
     # make sure we catch p-values equal to 1 despite left closure
     # use closed=:left because we have been using >= convention in this package
     # note that original paper uses > convention.

src/utils.jl

@@ -1,20 +1,5 @@
 ## utility functions ##
 
-function sort_if_needed(x; kws...)
-    if issorted(x; kws...)
-        return x
-    else
-        return sort(x; kws...)
-    end
-end
-
-function sort_if_needed!(x; kws...)
-    if !issorted(x; kws...)
-        sort!(x; kws...)
-    end
-end
-
-
 function unsort(x; kws...)
     y = copy(x)
     while issorted(y; kws...)

test/test-pi0-estimators.jl

@@ -73,7 +73,7 @@ using StatsBase
         # used for comparison and compactness
         function lsl_pi0_vec(pValues::AbstractVector{T}) where T <: AbstractFloat
             n = length(pValues)
-            pValues = MultipleTesting.sort_if_needed(pValues)
+            pValues = MultipleTesting.sort(pValues)
             s = (1 .- pValues) ./ (n:-1:1)
             d = diff(s) .< 0
             idx = something(findfirst(d), 0) + 1

test/test-utils.jl

@@ -57,31 +57,6 @@ using Test
     end
 
 
-    @testset "sort_if_needed" begin
-
-        x = rand(20)
-
-        sort_if_needed = MultipleTesting.sort_if_needed
-        sort_if_needed! = MultipleTesting.sort_if_needed!
-
-        # behaves as standard `sort`
-        @test sort_if_needed(x) == sort(x)
-        @test sort_if_needed(sort(x)) == sort(x)
-
-        # `sort` keywords work
-        @test sort_if_needed(x, rev = true) == sort(x, rev = true)
-        @test sort_if_needed(sort(x, rev = true), rev = true) == sort(x, rev = true)
-
-        x = rand(20)
-        y = copy(x)
-        sort_if_needed!(y)
-        @test y == sort(x)
-        sort_if_needed!(y)
-        @test y == sort(x)
-
-    end
-
-
     @testset "unsort" begin
 
         n = 20