Commit 18232b4
Split RTCDataChannel-send-close.html web test to avoid timeouts (web-platform-tests#54772)
Addresses flakes by dividing the test into three new tests. Adds one
test for each type of data sent: Blob, string, and ArrayBuffer. Adds
`RTCDataChannel-send-close-helper.js` for shared test code.
The original test ran for ~45 seconds on my powerful developer machine.
Each new tests takes ~15 seconds.
Re-enables the test on win-arm and Linux. MacOS still fails with the
following network errors, that lead to a timeout:
```
services/network/p2p/socket_manager.cc:137 Failed to resolve address for
9218b16a-a784-40f0-9384-0dec7712202d.local., errorcode: -105
third_party/webrtc/p2p/base/p2p_transport_channel.cc:1274 Failed to
resolve ICE candidate hostname
9218b16a-a784-40f0-9384-0dec7712202d.local with error -1
```
Bug: 377072733 414687402
Change-Id: I2e367bdcb9185437d8db4840b5b3ccc70143de7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6913845
Reviewed-by: Henrik Boström <hbos@chromium.org>
Reviewed-by: Mason Freed <masonf@chromium.org>
Commit-Queue: Steve Becker <stevebe@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1513170}
Co-authored-by: Steve Becker <stevebe@microsoft.com>1 parent bc09e43 commit 18232b4
File tree
5 files changed
+116
-123
lines changed- webrtc
5 files changed
+116
-123
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
This file was deleted.
0 commit comments