[3.x] Cast ini values to integer in getFileUploadMaxSize #78
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue joomla/joomla-cms#45905
Summary of Changes
This pull request (PR) changes the internal variables which are used in the
Helper::getFileUploadMaxSize()method to calculate the result to be integer by casting the result of theself::parseSizecalls (which always return floats as being the result ofroundbut only can have integer values) to integer before using integer comparisons on these variables.Currently the
$maxSize === 0check is always false as$maxSizeis always a float.Testing Instructions
Expected result
Extension should be uploaded and deployed successfully.
Actual result
Upload fails instant with the following message:
"The selected file cannot be uploaded as it is bigger than the maximum upload size."
Documentation Changes Required
None.