Skip to content

Commit f9a47c8

Browse files
authored
Merge pull request #132 from jolicode/php74
Drop support for PHP < 7.4
2 parents d0b53fd + fe64aa2 commit f9a47c8

File tree

5 files changed

+16
-12
lines changed

5 files changed

+16
-12
lines changed

.github/workflows/ci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,11 +44,11 @@ jobs:
4444
strategy:
4545
fail-fast: false
4646
matrix:
47-
php-version: [ '7.2', '7.3', '7.4', '8.0' ]
47+
php-version: [ '7.4', '8.0' ]
4848
composer-flags: [ '' ]
4949
name: [ '' ]
5050
include:
51-
- php-version: 7.2
51+
- php-version: 7.4
5252
composer-flags: '--prefer-lowest'
5353
name: '(prefer lowest dependencies)'
5454

.php-cs-fixer.php

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,13 @@
1212
*/
1313

1414
$fileHeaderComment = <<<'EOF'
15-
This file is part of JoliCode's Slack PHP API project.
15+
This file is part of JoliCode's Slack PHP API project.
1616
17-
(c) JoliCode <coucou@jolicode.com>
17+
(c) JoliCode <coucou@jolicode.com>
1818
19-
For the full copyright and license information, please view the LICENSE
20-
file that was distributed with this source code.
21-
EOF;
19+
For the full copyright and license information, please view the LICENSE
20+
file that was distributed with this source code.
21+
EOF;
2222

2323
$finder = PhpCsFixer\Finder::create()
2424
->in(__DIR__)
@@ -32,7 +32,7 @@
3232
return (new PhpCsFixer\Config())
3333
->setRiskyAllowed(true)
3434
->setRules([
35-
'@PHP71Migration' => true,
35+
'@PHP74Migration' => true,
3636
'@PhpCsFixer' => true,
3737
'@Symfony' => true,
3838
'@Symfony:risky' => true,

CHANGELOG.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
# Changes between versions
22

3+
## 4.4.0 (not released yet)
4+
5+
* Drop support for PHP <7.4
6+
37
## 4.3.0 (2021-05-31)
48

59
* Add responseMetadata to `SlackErrorResponse` exception to ease debug
@@ -18,7 +22,7 @@
1822

1923
* **Specification override** Fix some `timestamp` from integer to mixed string and integer to support old messages
2024
* **Specification override** Change some `latest` / `oldest` / `ts_from` / `ts_to` query parameters from integer to string
21-
* Improve carbon footprint by removing unnecessary files from git export
25+
* Improve carbon footprint by removing unnecessary files from git export
2226

2327
## 4.0.0 (2020-12-28)
2428

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
}
2727
},
2828
"require": {
29-
"php": ">= 7.2",
29+
"php": ">=7.4",
3030
"jane-php/open-api-runtime": "~6.3.0",
3131
"psr/http-client-implementation": "*",
3232
"php-http/client-common": "^1.9 || ^2.0",

src/Client.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,8 @@ public function iterate(string $method, array $arguments): iterable
4747
{
4848
$getter = 'get' . self::CURSOR_PAGINATION[$method];
4949

50-
$arguments[0] = $arguments[0] ?? [];
51-
$arguments[0]['limit'] = $arguments[0]['limit'] ?? 1000;
50+
$arguments[0] ??= [];
51+
$arguments[0]['limit'] ??= 1000;
5252

5353
$cursor = '';
5454

0 commit comments

Comments
 (0)