Apply suggestion from #83 to make the timestamp field mixed (#102)

* Apply suggestion from #83 to make the timestamp field mixed
* Fix old PHPUNIT compatibility

Author: damienalexandre

CHANGELOG.md

@@ -2,6 +2,8 @@
 
 ## Unreleased
 
+* **Specification override** Fix some `timestamp` from integer to mixed string and integer to support old messages
+
 ## 4.0.0 (2020-12-28)
 
 * **Breaking** Specification update to latest Slack official version - see slackapi/slack-api-specs#44

generated/Model/ObjsComment.php

@@ -52,7 +52,7 @@ class ObjsComment
      */
     protected $reactions;
     /**
-     * @var int|null
+     * @var string|int|null
      */
     protected $timestamp;
     /**
@@ -186,12 +186,18 @@ public function setReactions(?array $reactions): self
         return $this;
     }
 
-    public function getTimestamp(): ?int
+    /**
+     * @return string|int|null
+     */
+    public function getTimestamp()
     {
         return $this->timestamp;
     }
 
-    public function setTimestamp(?int $timestamp): self
+    /**
+     * @param string|int|null $timestamp
+     */
+    public function setTimestamp($timestamp): self
     {
         $this->timestamp = $timestamp;
 

generated/Model/ObjsFile.php

@@ -276,7 +276,7 @@ class ObjsFile
      */
     protected $thumbTiny;
     /**
-     * @var int|null
+     * @var string|int|null
      */
     protected $timestamp;
     /**
@@ -1124,12 +1124,18 @@ public function setThumbTiny(?string $thumbTiny): self
         return $this;
     }
 
-    public function getTimestamp(): ?int
+    /**
+     * @return string|int|null
+     */
+    public function getTimestamp()
     {
         return $this->timestamp;
     }
 
-    public function setTimestamp(?int $timestamp): self
+    /**
+     * @param string|int|null $timestamp
+     */
+    public function setTimestamp($timestamp): self
     {
         $this->timestamp = $timestamp;
 

generated/Normalizer/ObjsCommentNormalizer.php

@@ -104,7 +104,13 @@ public function denormalize($data, $class, $format = null, array $context = [])
             $object->setReactions(null);
         }
         if (\array_key_exists('timestamp', $data) && null !== $data['timestamp']) {
-            $object->setTimestamp($data['timestamp']);
+            $value_2 = $data['timestamp'];
+            if (\is_string($data['timestamp'])) {
+                $value_2 = $data['timestamp'];
+            } elseif (\is_int($data['timestamp'])) {
+                $value_2 = $data['timestamp'];
+            }
+            $object->setTimestamp($value_2);
         } elseif (\array_key_exists('timestamp', $data) && null === $data['timestamp']) {
             $object->setTimestamp(null);
         }
@@ -147,7 +153,13 @@ public function normalize($object, $format = null, array $context = [])
             }
             $data['reactions'] = $values_1;
         }
-        $data['timestamp'] = $object->getTimestamp();
+        $value_2 = $object->getTimestamp();
+        if (\is_string($object->getTimestamp())) {
+            $value_2 = $object->getTimestamp();
+        } elseif (\is_int($object->getTimestamp())) {
+            $value_2 = $object->getTimestamp();
+        }
+        $data['timestamp'] = $value_2;
         $data['user'] = $object->getUser();
 
         return $data;

generated/Normalizer/ObjsFileNormalizer.php

@@ -396,7 +396,13 @@ public function denormalize($data, $class, $format = null, array $context = [])
             $object->setThumbTiny(null);
         }
         if (\array_key_exists('timestamp', $data) && null !== $data['timestamp']) {
-            $object->setTimestamp($data['timestamp']);
+            $value_5 = $data['timestamp'];
+            if (\is_string($data['timestamp'])) {
+                $value_5 = $data['timestamp'];
+            } elseif (\is_int($data['timestamp'])) {
+                $value_5 = $data['timestamp'];
+            }
+            $object->setTimestamp($value_5);
         } elseif (\array_key_exists('timestamp', $data) && null === $data['timestamp']) {
             $object->setTimestamp(null);
         }
@@ -658,7 +664,13 @@ public function normalize($object, $format = null, array $context = [])
             $data['thumb_tiny'] = $object->getThumbTiny();
         }
         if (null !== $object->getTimestamp()) {
-            $data['timestamp'] = $object->getTimestamp();
+            $value_5 = $object->getTimestamp();
+            if (\is_string($object->getTimestamp())) {
+                $value_5 = $object->getTimestamp();
+            } elseif (\is_int($object->getTimestamp())) {
+                $value_5 = $object->getTimestamp();
+            }
+            $data['timestamp'] = $value_5;
         }
         if (null !== $object->getTitle()) {
             $data['title'] = $object->getTitle();

resources/slack-openapi-patched.json

@@ -404,7 +404,10 @@
                     "type": "array"
                 },
                 "timestamp": {
-                    "type": "integer"
+                    "type": [
+                        "integer",
+                        "string"
+                    ]
                 },
                 "user": {
                     "$ref": "#/definitions/defs_user_id"
@@ -1072,7 +1075,10 @@
                     "type": "string"
                 },
                 "timestamp": {
-                    "type": "integer"
+                    "type": [
+                        "integer",
+                        "string"
+                    ]
                 },
                 "title": {
                     "type": "string"