fix(compiler-core): create FOR node in AST when v-for + v-slot are combined #16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
<template v-for v-slot>is used, the AST incorrectly keeps both directives on an ELEMENT node instead of creating a FOR node wrapping an ELEMENT with slot directive. This breaks AST consumers like Volar.Before:
ELEMENT(directives: for, slot)After:
FOR→ELEMENT(directives: slot)Changes
v-forstructural transform to proceed whenv-slotis present (previously skipped all structural directives)<template v-for v-slot>(handled bybuildSlots)v-slotv-slotinbuildSlotsTest
Added
vForSlotIssue.spec.tsverifying correct AST structure.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
googlechromelabs.github.io/usr/local/bin/node node install.mjs(dns block)https://storage.googleapis.com/chrome-for-testing-public/142.0.7444.59/linux64/chrome-linux64.zip/usr/local/bin/node node install.mjs(http block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
compiler-domcreate unexpected nodes withv-for+v-slotvuejs/core#3498💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.