Merge pull request #211 from jeremykenedy/analysis-PGJJge

Apply fixes from StyleCI

Author: jeremykenedy

src/Database/TestMigrations/2014_10_12_000000_create_users_table.php

@@ -6,8 +6,7 @@
 use Illuminate\Database\Schema\Blueprint;
 use Illuminate\Support\Facades\Schema;
 
-return new class extends Migration
-{
+return new class() extends Migration {
     /**
      * Run the migrations.
      *

src/Traits/RolesAndPermissionsHelpersTrait.php

@@ -717,7 +717,7 @@ public function getSortedPermissonsWithRolesAndUsers($sortedRolesWithUsers, $per
     /**
      * Removes an users and permissions from role.
      *
-     * @param Role$role   The role
+     * @param Role $role The role
      *
      * @return void
      */
@@ -761,7 +761,6 @@ public function removeUsersAndRolesFromPermissions($permission)
 
         foreach ($sortedPermissionsRolesUsers as $sortedPermissionsRolesUsersKey => $sortedPermissionsRolesUsersItem) {
             if ($sortedPermissionsRolesUsersItem['permission']->id === $permission->id) {
-
                 // Remove Permission from roles
                 foreach ($sortedPermissionsRolesUsersItem['roles'] as $permissionRoleKey => $permissionRoleItem) {
                     $permissionRoleItem->detachPermission($permission);

src/routes/web.php

@@ -12,7 +12,6 @@
     'namespace'     => 'jeremykenedy\LaravelRoles\App\Http\Controllers',
     'prefix'        => config('roles.GUIRoutesPrefix'),
 ], function () {
-
     // Dashboards and CRUD Routes
     Route::resource('roles', 'LaravelRolesController');
     Route::resource('permissions', 'LaravelPermissionsController');

tests/Feature/NPlusOneQueriesTest.php

@@ -32,7 +32,7 @@ protected function setUp(): void
         $this->assertEquals($this->rolesCount, config('roles.models.role')::count());
         $this->assertEquals($this->permissionsCount, config('roles.models.permission')::count());
 
-        DB::listen(function(QueryExecuted $query) {
+        DB::listen(function (QueryExecuted $query) {
             $this->queries++;
         });
     }
@@ -43,7 +43,7 @@ public function canPreloadRolesOnCollection(): void
         $roleIds = config('roles.models.role')::pluck('id');
 
         User::factory($this->usersCount)->create()
-            ->each(function(User $user) use ($roleIds) {
+            ->each(function (User $user) use ($roleIds) {
                 $user->roles()->attach($roleIds);
             });
         $this->assertEquals($this->usersCount, User::count() - $this->usersCountCorrection);
@@ -54,7 +54,7 @@ public function canPreloadRolesOnCollection(): void
         $users = User::get();
         $this->assertQueries(1);
 
-        $users->each(function(User $user) {
+        $users->each(function (User $user) {
             $user->getRoles();
         });
         $this->queries = $this->queries - $this->usersCountCorrection;
@@ -64,7 +64,7 @@ public function canPreloadRolesOnCollection(): void
         $users = User::with('roles')->get();
         $this->assertQueries(2);
 
-        $users->each(function(User $user) {
+        $users->each(function (User $user) {
             $user->getRoles();
         });
         $this->assertQueries(0);
@@ -142,7 +142,7 @@ public function canPreloadPermissionsOnCollection(): void
         $roleIds = config('roles.models.role')::pluck('id');
 
         User::factory($this->usersCount)->create()
-            ->each(function(User $user) use ($roleIds) {
+            ->each(function (User $user) use ($roleIds) {
                 $user->roles()->attach($roleIds);
             });
         $this->assertEquals($this->usersCount, User::count() - $this->usersCountCorrection);
@@ -153,7 +153,7 @@ public function canPreloadPermissionsOnCollection(): void
         $users = User::get();
         $this->assertQueries(1);
 
-        $users->each(function(User $user) {
+        $users->each(function (User $user) {
             $user->getPermissions();
         });
         // rolePermissions(+getRoles) + userPermissions
@@ -164,7 +164,7 @@ public function canPreloadPermissionsOnCollection(): void
         $users = User::with('roles', 'userPermissions')->get();
         $this->assertQueries(3);
 
-        $users->each(function(User $user) {
+        $users->each(function (User $user) {
             $user->getPermissions();
         });
         // TODO: optimize via relations: userPermissions and rolePermissions