Remove symref test conditionals

All supported versions of command line git include symref support so
there is no need for conditionals that check for symref support before
running the tests.

Author: MarkEWaite

src/test/java/org/jenkinsci/plugins/gitclient/CliGitAPIImplTest.java

@@ -16,11 +16,6 @@ protected GitClient setupGitAPI(File ws) throws Exception {
         return Git.with(listener, env).in(ws).using("git").getClient();
     }
 
-    @Override
-    protected boolean hasWorkingGetRemoteSymbolicReferences() {
-        return ((CliGitAPIImpl) (w.git)).isAtLeastVersion(2, 8, 0, 0);
-    }
-
     public static class VersionTest {
 
         private boolean expectedIsAtLeastVersion;

src/test/java/org/jenkinsci/plugins/gitclient/GitAPITestUpdate.java

@@ -1219,8 +1219,6 @@ public void testGetHeadRevNamespacesWithSimpleBranchNames() throws Exception {
         }
     }
 
-    protected abstract boolean hasWorkingGetRemoteSymbolicReferences();
-
     private Properties parseLsRemote(File file) throws IOException {
         Properties properties = new Properties();
         Pattern pattern = Pattern.compile("([a-f0-9]{40})\\s*(.*)");
@@ -1243,10 +1241,6 @@ private Properties parseLsRemote(File file) throws IOException {
      */
     @Test
     public void testGetRemoteSymbolicReferencesWithMatchingPattern() throws Exception {
-        if (!hasWorkingGetRemoteSymbolicReferences()) {
-            /* Do not distract warnings system by using assumeThat to skip tests */
-            return;
-        }
         Map<String, String> references = w.git.getRemoteSymbolicReferences(remoteMirrorURL, Constants.HEAD);
         assertThat(references, hasEntry(is(Constants.HEAD), is(Constants.R_HEADS + DEFAULT_JGIT_BRANCH_NAME)));
         assertThat(references.size(), is(1));
@@ -1800,10 +1794,6 @@ public void testRevListRemoteBranch() throws Exception {
      */
     @Test
     public void testGetRemoteSymbolicReferences() throws Exception {
-        if (!hasWorkingGetRemoteSymbolicReferences()) {
-            /* Do not distract warnings system by using assumeThat to skip tests */
-            return;
-        }
         Map<String, String> references = w.git.getRemoteSymbolicReferences(remoteMirrorURL, null);
         assertThat(references, hasEntry(is(Constants.HEAD), is(Constants.R_HEADS + DEFAULT_JGIT_BRANCH_NAME)));
     }

src/test/java/org/jenkinsci/plugins/gitclient/JGitAPIImplTest.java

@@ -11,11 +11,6 @@ protected GitClient setupGitAPI(File ws) throws Exception {
         return Git.with(listener, env).in(ws).using("jgit").getClient();
     }
 
-    @Override
-    protected boolean hasWorkingGetRemoteSymbolicReferences() {
-        return true; // JGit 5.10 has getRemoteSymbolicReferences, prior did not
-    }
-
     @Override
     protected boolean getTimeoutVisibleInCurrentTest() {
         return true; // git client plugin 3.11.0 supports JGit timeout

src/test/java/org/jenkinsci/plugins/gitclient/JGitApacheAPIImplTest.java

@@ -11,11 +11,6 @@ protected GitClient setupGitAPI(File ws) throws Exception {
         return Git.with(listener, env).in(ws).using("jgitapache").getClient();
     }
 
-    @Override
-    protected boolean hasWorkingGetRemoteSymbolicReferences() {
-        return true; // JGit 5.10 gets remote symbolic references, prior did not
-    }
-
     @Override
     protected boolean getTimeoutVisibleInCurrentTest() {
         return true; // git client plugin 3.11.0 supports JGit timeout