Skip to content

add readFullDataset to jaspTools #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JorisGoosen wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add readFullDataset to jaspTools #54

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions R/rbridge.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,14 @@
return(dataset)
}

.readFullDatasetToEnd <- function() {

dataset <- .getInternal("dataset")
dataset <- loadCorrectDataset(dataset)
Comment on lines +48 to +49
Copy link
Contributor

@vandenman vandenman Jul 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this also do the remainder of

jaspTools/R/dataset.R

Lines 58 to 82 in 8a5cf99

dataset <- loadCorrectDataset(datasetPathOrObject)
# repair any names like "", which cause false positives in findAllColumnNamesAndTypes
# because empty options are often ""
cnms <- colnames(dataset)
if (any(cnms == "")) {
bad <- which(cnms == "")
newCnms <- make.names(cnms)
cnms[bad] <- newCnms[bad]
colnames(dataset) <- cnms
}
# columns <- findAllColumnNamesInOptions(options, colnames(dataset))
temp <- findAllColumnNamesAndTypes(options, colnames(dataset))
variables <- temp[["variables"]]
types <- temp[["types"]]
# remove any duplicated variables for now
nonDuplicatedIdx <- !duplicated(variables)
variables <- variables[nonDuplicatedIdx]
types <- types[nonDuplicatedIdx]
dataset <- convertToTypes(dataset[variables], types, datasetPathOrObject)

Perhaps wrap it in a function to use in both places?

Copy link
Contributor Author

@JorisGoosen JorisGoosen Jul 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose?

Anyway, my vacation has started, and I wont really have time to look at this until beginning of august


return(dataset)
}

.readDataSetHeaderNative <- function(columns = c(), columns.as.numeric = c(), columns.as.ordinal = c(),
columns.as.factor = c(), all.columns = FALSE) {

Expand Down
Loading