Skip to content

Commit c3eacaf

Browse files
committed
fix: ruff errors and add ruff to pyproject dev dependancies to avoid running pre-commit for ruff checking
1 parent 736d17f commit c3eacaf

File tree

5 files changed

+24
-24
lines changed

5 files changed

+24
-24
lines changed

pyproject.toml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -110,3 +110,8 @@ asyncio_mode = "auto"
110110
asyncio_default_fixture_loop_scope = "function"
111111
python_classes = "Test*"
112112
python_functions = "test_*"
113+
114+
[dependency-groups]
115+
dev = [
116+
"ruff>=0.12.1",
117+
]

src/server/main.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,15 +6,14 @@
66
from pathlib import Path
77

88
from dotenv import load_dotenv
9-
from fastapi import FastAPI, Request
9+
from fastapi import FastAPI
1010
from fastapi.responses import FileResponse, HTMLResponse
1111
from fastapi.staticfiles import StaticFiles
1212
from slowapi.errors import RateLimitExceeded
1313
from starlette.middleware.trustedhost import TrustedHostMiddleware
1414

1515
from server.routers import dynamic, index
1616
from server.routers.ingest import router as ingest
17-
from server.server_config import templates
1817
from server.server_utils import lifespan, limiter, rate_limit_exception_handler
1918

2019
# Load environment variables from .env file
@@ -73,6 +72,7 @@ async def head_root() -> HTMLResponse:
7372
"""
7473
return HTMLResponse(content=None, headers={"content-type": "text/html; charset=utf-8"})
7574

75+
7676
@app.get("/robots.txt", include_in_schema=False)
7777
async def robots() -> FileResponse:
7878
"""Serve the ``robots.txt`` file to guide search engine crawlers.

src/server/routers/dynamic.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,7 @@
33
from fastapi import APIRouter, Request
44
from fastapi.responses import HTMLResponse
55

6-
from gitingest.utils.compat_typing import Annotated
76
from server.server_config import templates
8-
from server.server_utils import limiter
97

108
router = APIRouter()
119

@@ -38,4 +36,4 @@ async def catch_all(request: Request, full_path: str) -> HTMLResponse:
3836
"repo_url": full_path,
3937
"default_file_size": 243,
4038
},
41-
)
39+
)

src/server/routers/index.py

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,9 @@
11
"""Module defining the FastAPI router for the home page of the application."""
22

3-
from fastapi import APIRouter, Depends, Request
3+
from fastapi import APIRouter, Request
44
from fastapi.responses import HTMLResponse
55

6-
from gitingest.utils.compat_typing import Annotated
7-
from server.models import QueryForm
8-
from server.query_processor import process_query
96
from server.server_config import EXAMPLE_REPOS, templates
10-
from server.server_utils import limiter
117

128
router = APIRouter()
139

@@ -38,4 +34,4 @@ async def home(request: Request) -> HTMLResponse:
3834
"examples": EXAMPLE_REPOS,
3935
"default_file_size": 243,
4036
},
41-
)
37+
)

tests/test_flow_integration.py

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,6 @@ def mock_static_files(mocker: MockerFixture) -> None:
3232
return mock_static
3333

3434

35-
36-
37-
3835
@pytest.fixture(scope="module", autouse=True)
3936
def cleanup_tmp_dir() -> Generator[None, None, None]:
4037
"""Remove ``/tmp/gitingest`` after this test-module is done."""
@@ -61,7 +58,7 @@ async def test_remote_repository_analysis(request: pytest.FixtureRequest) -> Non
6158

6259
response = client.post("/api/ingest", data=form_data)
6360
assert response.status_code == status.HTTP_200_OK, f"Form submission failed: {response.text}"
64-
61+
6562
# Check that response is JSON
6663
response_data = response.json()
6764
assert "result" in response_data
@@ -87,7 +84,7 @@ async def test_invalid_repository_url(request: pytest.FixtureRequest) -> None:
8784
response = client.post("/api/ingest", data=form_data)
8885
# Should return 400 for invalid repository
8986
assert response.status_code == status.HTTP_400_BAD_REQUEST, f"Request failed: {response.text}"
90-
87+
9188
# Check that response is JSON error
9289
response_data = response.json()
9390
assert "error" in response_data
@@ -108,8 +105,9 @@ async def test_large_repository(request: pytest.FixtureRequest) -> None:
108105

109106
response = client.post("/api/ingest", data=form_data)
110107
# This might fail with 400 if repo doesn't exist, or succeed with 200
111-
assert response.status_code in [status.HTTP_200_OK, status.HTTP_400_BAD_REQUEST], f"Request failed: {response.text}"
112-
108+
_valid = [status.HTTP_200_OK, status.HTTP_400_BAD_REQUEST]
109+
assert response.status_code in _valid, f"Request failed: {response.text}"
110+
113111
response_data = response.json()
114112
if response.status_code == status.HTTP_200_OK:
115113
assert "result" in response_data
@@ -132,8 +130,9 @@ def make_request() -> None:
132130
"token": "",
133131
}
134132
response = client.post("/api/ingest", data=form_data)
135-
assert response.status_code in [status.HTTP_200_OK, status.HTTP_400_BAD_REQUEST], f"Request failed: {response.text}"
136-
133+
_valid = [status.HTTP_200_OK, status.HTTP_400_BAD_REQUEST]
134+
assert response.status_code in _valid, f"Request failed: {response.text}"
135+
137136
response_data = response.json()
138137
if response.status_code == status.HTTP_200_OK:
139138
assert "result" in response_data
@@ -160,8 +159,9 @@ async def test_large_file_handling(request: pytest.FixtureRequest) -> None:
160159
}
161160

162161
response = client.post("/api/ingest", data=form_data)
163-
assert response.status_code in [status.HTTP_200_OK, status.HTTP_400_BAD_REQUEST], f"Request failed: {response.text}"
164-
162+
_valid = [status.HTTP_200_OK, status.HTTP_400_BAD_REQUEST]
163+
assert response.status_code in _valid, f"Request failed: {response.text}"
164+
165165
response_data = response.json()
166166
if response.status_code == status.HTTP_200_OK:
167167
assert "result" in response_data
@@ -183,8 +183,9 @@ async def test_repository_with_patterns(request: pytest.FixtureRequest) -> None:
183183
}
184184

185185
response = client.post("/api/ingest", data=form_data)
186-
assert response.status_code in [status.HTTP_200_OK, status.HTTP_400_BAD_REQUEST], f"Request failed: {response.text}"
187-
186+
_valid = [status.HTTP_200_OK, status.HTTP_400_BAD_REQUEST]
187+
assert response.status_code in _valid, f"Request failed: {response.text}"
188+
188189
response_data = response.json()
189190
if response.status_code == status.HTTP_200_OK:
190191
assert "result" in response_data

0 commit comments

Comments
 (0)