#21 improve loop

Author: itosho

src/Model/Behavior/InsertBehavior.php

@@ -121,15 +121,16 @@ private function buildTmpTableSelectQuery($escapedData)
             ->getConnection()
             ->getDriver();
         $schema = [];
+        $binds = [];
         foreach ($escapedData as $key => $value) {
             $col = $driver->quoteIdentifier($key);
             if ($value === 'NULL') {
                 $schema[] = "{$value} AS {$col}";
             } else {
-                $bindKey = strtolower(trim($key));
-                $schema[] = ":{$bindKey} AS {$col}";
+                $bindKey = ':' . strtolower(trim($key));
+                $binds[$bindKey] = $value;
+                $schema[] = "{$bindKey} AS {$col}";
             }
-
         }
 
         $tmpTable = TableRegistry::getTableLocator()->get('tmp', [
@@ -141,14 +142,10 @@ private function buildTmpTableSelectQuery($escapedData)
             ->from(
                 sprintf('(SELECT %s) as tmp', implode(',', $schema))
             );
-        foreach ($escapedData as $key => $value) {
-            if ($value !== 'NULL') {
-                $bindKey = strtolower(trim($key));
-                $query->bind(":{$bindKey}", $value);
-            }
+        foreach ($binds as $key => $value) {
+            $query->bind($key, $value);
         }
 
-
         /** @var Query $selectQuery */
         $selectQuery = $query;