Rename internal method createXmpMetadata into updateDefaultXmpMetadata

Author: yulian-gaponenko

kernel/src/main/java/com/itextpdf/kernel/pdf/PdfDocument.java

@@ -275,62 +275,6 @@ public void setXmpMetadata(XMPMeta xmpMeta) throws XMPException {
         setXmpMetadata(xmpMeta, serializeOptions);
     }
 
-    protected void updateXmpMetadata() {
-        try {
-            if (writer.properties.addXmpMetadata) {
-                setXmpMetadata(createXmpMetadata());
-            }
-        } catch (XMPException e) {
-            Logger logger = LoggerFactory.getLogger(PdfDocument.class);
-            logger.error(LogMessageConstant.EXCEPTION_WHILE_UPDATING_XMPMETADATA, e);
-        }
-    }
-
-    protected XMPMeta createXmpMetadata() throws XMPException {
-        XMPMeta xmpMeta = XMPMetaFactory.parseFromBuffer(getXmpMetadata(true));
-        PdfDictionary docInfo = info.getPdfObject();
-        if (docInfo != null) {
-            PdfName key;
-            PdfObject obj;
-            String value;
-            for (PdfName pdfName : docInfo.keySet()) {
-                key = pdfName;
-                obj = docInfo.get(key);
-                if (obj == null)
-                    continue;
-                if (obj.getType() != PdfObject.STRING)
-                    continue;
-                value = ((PdfString) obj).toUnicodeString();
-                if (PdfName.Title.equals(key)) {
-                    xmpMeta.setLocalizedText(XMPConst.NS_DC, PdfConst.Title, XMPConst.X_DEFAULT, XMPConst.X_DEFAULT, value);
-                } else if (PdfName.Author.equals(key)) {
-                    xmpMeta.appendArrayItem(XMPConst.NS_DC, PdfConst.Creator, new PropertyOptions(PropertyOptions.ARRAY_ORDERED), value, null);
-                } else if (PdfName.Subject.equals(key)) {
-                    xmpMeta.setLocalizedText(XMPConst.NS_DC, PdfConst.Description, XMPConst.X_DEFAULT, XMPConst.X_DEFAULT, value);
-                } else if (PdfName.Keywords.equals(key)) {
-                    for (String v : value.split(",|;")) {
-                        if (v.trim().length() > 0) {
-                            xmpMeta.appendArrayItem(XMPConst.NS_DC, PdfConst.Subject, new PropertyOptions(PropertyOptions.ARRAY), v.trim(), null);
-                        }
-                    }
-                    xmpMeta.setProperty(XMPConst.NS_PDF, PdfConst.Keywords, value);
-                } else if (PdfName.Creator.equals(key)) {
-                    xmpMeta.setProperty(XMPConst.NS_XMP, PdfConst.CreatorTool, value);
-                } else if (PdfName.Producer.equals(key)) {
-                    xmpMeta.setProperty(XMPConst.NS_PDF, PdfConst.Producer, value);
-                } else if (PdfName.CreationDate.equals(key)) {
-                    xmpMeta.setProperty(XMPConst.NS_XMP, PdfConst.CreateDate, PdfDate.getW3CDate(value));
-                } else if (PdfName.ModDate.equals(key)) {
-                    xmpMeta.setProperty(XMPConst.NS_XMP, PdfConst.ModifyDate, PdfDate.getW3CDate(value));
-                }
-            }
-        }
-        if (isTagged() && !isXmpMetaHasProperty(xmpMeta, XMPConst.NS_PDFUA_ID, XMPConst.PART)) {
-            xmpMeta.setPropertyInteger(XMPConst.NS_PDFUA_ID, XMPConst.PART, 1, new PropertyOptions(PropertyOptions.SEPARATE_NODE));
-        }
-        return xmpMeta;
-    }
-
     /**
      * Gets XMPMetadata.
      */
@@ -1445,6 +1389,62 @@ protected void open(PdfVersion newPdfVersion) {
         }
     }
 
+    protected void updateXmpMetadata() {
+        try {
+            if (writer.properties.addXmpMetadata) {
+                setXmpMetadata(updateDefaultXmpMetadata());
+            }
+        } catch (XMPException e) {
+            Logger logger = LoggerFactory.getLogger(PdfDocument.class);
+            logger.error(LogMessageConstant.EXCEPTION_WHILE_UPDATING_XMPMETADATA, e);
+        }
+    }
+
+    protected XMPMeta updateDefaultXmpMetadata() throws XMPException {
+        XMPMeta xmpMeta = XMPMetaFactory.parseFromBuffer(getXmpMetadata(true));
+        PdfDictionary docInfo = info.getPdfObject();
+        if (docInfo != null) {
+            PdfName key;
+            PdfObject obj;
+            String value;
+            for (PdfName pdfName : docInfo.keySet()) {
+                key = pdfName;
+                obj = docInfo.get(key);
+                if (obj == null)
+                    continue;
+                if (obj.getType() != PdfObject.STRING)
+                    continue;
+                value = ((PdfString) obj).toUnicodeString();
+                if (PdfName.Title.equals(key)) {
+                    xmpMeta.setLocalizedText(XMPConst.NS_DC, PdfConst.Title, XMPConst.X_DEFAULT, XMPConst.X_DEFAULT, value);
+                } else if (PdfName.Author.equals(key)) {
+                    xmpMeta.appendArrayItem(XMPConst.NS_DC, PdfConst.Creator, new PropertyOptions(PropertyOptions.ARRAY_ORDERED), value, null);
+                } else if (PdfName.Subject.equals(key)) {
+                    xmpMeta.setLocalizedText(XMPConst.NS_DC, PdfConst.Description, XMPConst.X_DEFAULT, XMPConst.X_DEFAULT, value);
+                } else if (PdfName.Keywords.equals(key)) {
+                    for (String v : value.split(",|;")) {
+                        if (v.trim().length() > 0) {
+                            xmpMeta.appendArrayItem(XMPConst.NS_DC, PdfConst.Subject, new PropertyOptions(PropertyOptions.ARRAY), v.trim(), null);
+                        }
+                    }
+                    xmpMeta.setProperty(XMPConst.NS_PDF, PdfConst.Keywords, value);
+                } else if (PdfName.Creator.equals(key)) {
+                    xmpMeta.setProperty(XMPConst.NS_XMP, PdfConst.CreatorTool, value);
+                } else if (PdfName.Producer.equals(key)) {
+                    xmpMeta.setProperty(XMPConst.NS_PDF, PdfConst.Producer, value);
+                } else if (PdfName.CreationDate.equals(key)) {
+                    xmpMeta.setProperty(XMPConst.NS_XMP, PdfConst.CreateDate, PdfDate.getW3CDate(value));
+                } else if (PdfName.ModDate.equals(key)) {
+                    xmpMeta.setProperty(XMPConst.NS_XMP, PdfConst.ModifyDate, PdfDate.getW3CDate(value));
+                }
+            }
+        }
+        if (isTagged() && !isXmpMetaHasProperty(xmpMeta, XMPConst.NS_PDFUA_ID, XMPConst.PART)) {
+            xmpMeta.setPropertyInteger(XMPConst.NS_PDFUA_ID, XMPConst.PART, 1, new PropertyOptions(PropertyOptions.SEPARATE_NODE));
+        }
+        return xmpMeta;
+    }
+
     /**
      * List all newly added or loaded fonts
      *

pdfa/src/main/java/com/itextpdf/pdfa/PdfADocument.java

@@ -208,7 +208,7 @@ public PdfAConformanceLevel getConformanceLevel() {
     @Override
     protected void updateXmpMetadata() {
         try {
-            XMPMeta xmpMeta = createXmpMetadata();
+            XMPMeta xmpMeta = updateDefaultXmpMetadata();
             xmpMeta.setProperty(XMPConst.NS_PDFA_ID, XMPConst.PART, checker.getConformanceLevel().getPart());
             xmpMeta.setProperty(XMPConst.NS_PDFA_ID, XMPConst.CONFORMANCE, checker.getConformanceLevel().getConformance());
             if (this.isTagged()) {