Fix PdfReader#getBytes

Author: yulian-gaponenko

kernel/src/main/java/com/itextpdf/kernel/pdf/PdfReader.java

@@ -362,8 +362,7 @@ public static byte[] decodeBytes(byte[] b, PdfDictionary streamDictionary, Map<P
             PdfName filterName = (PdfName) filters.get(j);
             IFilterHandler filterHandler = filterHandlers.get(filterName);
             if (filterHandler == null)
-                filterHandler =  new DoNothingFilter();
-                //throw new PdfException(PdfException.Filter1IsNotSupported).setMessageParams(filterName); //TODO replace with some kind of UnsupportedException
+                throw new PdfException(PdfException.Filter1IsNotSupported).setMessageParams(filterName);
 
             PdfDictionary decodeParams;
             if (j < dp.size()) {
@@ -373,7 +372,7 @@ public static byte[] decodeBytes(byte[] b, PdfDictionary streamDictionary, Map<P
                 } else if (dpEntry.getType() == PdfObject.DICTIONARY) {
                     decodeParams = (PdfDictionary) dpEntry;
                 } else {
-                    throw new PdfException(PdfException.DecodeParameterType1IsNotSupported).setMessageParams(dpEntry.getClass().toString()); //TODO replace with some kind of UnsupportedException
+                    throw new PdfException(PdfException.DecodeParameterType1IsNotSupported).setMessageParams(dpEntry.getClass().toString());
                 }
             } else {
                 decodeParams = null;

kernel/src/main/java/com/itextpdf/kernel/pdf/canvas/parser/data/ImageRenderInfo.java

@@ -80,11 +80,10 @@ public ImageRenderInfo(Matrix ctm, PdfStream stream, PdfDictionary colorSpaceDic
      * Gets an image wrapped in ImageXObject.
      * You can:
      * <ul>
-     *     <li>get image bytes with {@link PdfImageXObject#getImageBytes(boolean)};</li>
+     *     <li>get image bytes with {@link PdfImageXObject#getImageBytes(boolean)}, these image bytes
+     *     represent native image, i.e you can write these bytes to disk and get just an usual image;</li>
      *     <li>obtain PdfStream object which contains image dictionary with {@link PdfImageXObject#getPdfObject()} method;</li>
      *     <li>convert image to {@link java.awt.image.BufferedImage} with {@link PdfImageXObject#getBufferedImage()};</li>
-     *     //TODO: correct this when something like convertToNativeImage method is implemented
-     *     <li>convert this image to native image with PdfImageXObject#convertToNativeImage;</li>
      * </ul>
      */
     public PdfImageXObject getImage() {

kernel/src/main/java/com/itextpdf/kernel/pdf/xobject/PdfImageXObject.java

@@ -130,7 +130,6 @@ public void flush() {
         }
     }
 
-    // TODO probably remove it. or may be not. images copying sounds not so bad.
     public PdfImageXObject copyTo(PdfDocument document) {
         PdfImageXObject image = new PdfImageXObject(getPdfObject().copyTo(document));
         image.width = width;

kernel/src/main/java/com/itextpdf/kernel/utils/PdfMerger.java

@@ -59,7 +59,7 @@ public class PdfMerger {
      * This class is used to merge a number of existing documents into one;
      * @param pdfDocument - the document into which source documents will be merged.
      */
-    public PdfMerger(PdfDocument pdfDocument){
+    public PdfMerger(PdfDocument pdfDocument) {
         this.pdfDocument = pdfDocument;
     }