Mark internal classes of PdfDictionaryEntrySet and PdfDictionaryValues as static

.net porting

Author: pavel-alay

kernel/src/main/java/com/itextpdf/kernel/pdf/PdfDictionaryEntrySet.java

@@ -68,7 +68,7 @@ public boolean remove(Object o) {
 
     @Override
     public Iterator<Map.Entry<PdfName, PdfObject>> iterator() {
-        return new DirectIterator();
+        return new DirectIterator(set.iterator());
     }
 
     @Override
@@ -81,8 +81,12 @@ public void clear() {
         set.clear();
     }
 
-    private class DirectIterator implements Iterator<Map.Entry<PdfName, PdfObject>> {
-        Iterator<Map.Entry<PdfName, PdfObject>> parentIterator = set.iterator();
+    private static class DirectIterator implements Iterator<Map.Entry<PdfName, PdfObject>> {
+        Iterator<Map.Entry<PdfName, PdfObject>> parentIterator;
+
+        public DirectIterator(Iterator<Map.Entry<PdfName, PdfObject>> parentIterator) {
+            this.parentIterator = parentIterator;
+        }
 
         @Override
         public boolean hasNext() {
@@ -100,11 +104,11 @@ public void remove() {
         }
     }
 
-    private class DirectEntry implements Map.Entry<PdfName, PdfObject> {
+    private static class DirectEntry implements Map.Entry<PdfName, PdfObject> {
 
         Map.Entry<PdfName, PdfObject> entry;
 
-        public DirectEntry(Map.Entry<PdfName, PdfObject> entry) {
+        DirectEntry(Map.Entry<PdfName, PdfObject> entry) {
             this.entry = entry;
         }
 

kernel/src/main/java/com/itextpdf/kernel/pdf/PdfDictionaryValues.java

@@ -101,11 +101,15 @@ public void clear() {
 
     @Override
     public Iterator<PdfObject> iterator() {
-        return new DirectIterator();
+        return new DirectIterator(collection.iterator());
     }
 
-    private class DirectIterator implements Iterator<PdfObject> {
-        Iterator<PdfObject> parentIterator = collection.iterator();
+    private static class DirectIterator implements Iterator<PdfObject> {
+        Iterator<PdfObject> parentIterator;
+
+        DirectIterator(Iterator<PdfObject> parentIterator) {
+            this.parentIterator = parentIterator;
+        }
 
         @Override
         public boolean hasNext() {