Merge pull request #17665 from iterate-ch/bugfix/MD-24982-factory

Fix occasional class cast exception when instantiating from factory w…

Author: dkocher

osx/src/main/java/ch/cyberduck/ui/cocoa/callback/PromptCertificateIdentityCallback.java

@@ -53,12 +53,13 @@ public class PromptCertificateIdentityCallback implements CertificateIdentityCal
 
     public PromptCertificateIdentityCallback(final ProxyController controller) {
         this.controller = controller;
-        this.window = null;
-    }
+        if(controller instanceof WindowController) {
+            this.window = ((WindowController) controller).window();
+        }
+        else {
+            this.window = null;
 
-    public PromptCertificateIdentityCallback(final WindowController controller) {
-        this.controller = controller;
-        this.window = controller.window();
+        }
     }
 
     @Override

osx/src/main/java/ch/cyberduck/ui/cocoa/callback/PromptCertificateTrustCallback.java

@@ -52,12 +52,13 @@ public class PromptCertificateTrustCallback implements CertificateTrustCallback
 
     public PromptCertificateTrustCallback(final ProxyController controller) {
         this.controller = controller;
-        this.window = null;
-    }
+        if(controller instanceof WindowController) {
+            this.window = ((WindowController) controller).window();
+        }
+        else {
+            this.window = null;
 
-    public PromptCertificateTrustCallback(final WindowController controller) {
-        this.controller = controller;
-        this.window = controller.window();
+        }
     }
 
     @Override

osx/src/main/java/ch/cyberduck/ui/cocoa/callback/PromptLoginCallback.java

@@ -64,15 +64,14 @@ public class PromptLoginCallback extends PromptPasswordCallback implements Login
     public PromptLoginCallback(final ProxyController controller) {
         super(controller);
         this.controller = controller;
-        this.window = null;
-    }
+        if(controller instanceof WindowController) {
+            this.window = ((WindowController) controller).window();
+        }
+        else {
+            this.window = null;
 
-    public PromptLoginCallback(final WindowController controller) {
-        super(controller);
-        this.controller = controller;
-        this.window = controller.window();
+        }
     }
-
     @Override
     public void await(final CountDownLatch signal, final Host bookmark, final String title, final String message) throws ConnectionCanceledException {
         log.debug("Display progress alert for {}", bookmark);