Drop support for stream based checksum calculation.

Author: dkocher

azure/src/main/java/ch/cyberduck/core/azure/AzureUploadFeature.java

@@ -24,10 +24,6 @@
 
 import com.azure.storage.blob.models.BlobType;
 
-import java.io.IOException;
-import java.security.MessageDigest;
-import java.security.NoSuchAlgorithmException;
-
 public class AzureUploadFeature extends DefaultUploadFeature<Void> {
 
     private final AzureSession session;
@@ -48,13 +44,4 @@ public Write.Append append(final Path file, final TransferStatus status) throws
         return Write.override;
     }
 
-    @Override
-    protected MessageDigest digest() throws IOException {
-        try {
-            return MessageDigest.getInstance("MD5");
-        }
-        catch(NoSuchAlgorithmException e) {
-            throw new IOException(e.getMessage(), e);
-        }
-    }
 }

backblaze/src/main/java/ch/cyberduck/core/b2/B2SingleUploadService.java

@@ -17,21 +17,8 @@
 
 import ch.cyberduck.core.http.HttpUploadFeature;
 
-import java.io.IOException;
-import java.security.MessageDigest;
-import java.security.NoSuchAlgorithmException;
-
 import synapticloop.b2.response.BaseB2Response;
 
 public class B2SingleUploadService extends HttpUploadFeature<BaseB2Response> {
 
-    @Override
-    protected MessageDigest digest() throws IOException {
-        try {
-            return MessageDigest.getInstance("SHA1");
-        }
-        catch(NoSuchAlgorithmException e) {
-            throw new IOException(e.getMessage(), e);
-        }
-    }
 }

core/src/main/java/ch/cyberduck/core/shared/DefaultUploadFeature.java

@@ -19,15 +19,13 @@
  */
 
 import ch.cyberduck.core.ConnectionCallback;
-import ch.cyberduck.core.DefaultIOExceptionMappingService;
 import ch.cyberduck.core.Local;
 import ch.cyberduck.core.Path;
 import ch.cyberduck.core.ProgressListener;
 import ch.cyberduck.core.exception.BackgroundException;
 import ch.cyberduck.core.features.Upload;
 import ch.cyberduck.core.features.Write;
 import ch.cyberduck.core.io.BandwidthThrottle;
-import ch.cyberduck.core.io.Checksum;
 import ch.cyberduck.core.io.StatusOutputStream;
 import ch.cyberduck.core.io.StreamCancelation;
 import ch.cyberduck.core.io.StreamCopier;
@@ -37,14 +35,10 @@
 import ch.cyberduck.core.transfer.TransferStatus;
 import ch.cyberduck.core.transfer.upload.UploadFilterOptions;
 
-import org.apache.commons.codec.binary.Hex;
 import org.apache.logging.log4j.LogManager;
 import org.apache.logging.log4j.Logger;
 
-import java.io.IOException;
 import java.io.InputStream;
-import java.security.DigestInputStream;
-import java.security.MessageDigest;
 
 public class DefaultUploadFeature<Reply> implements Upload<Reply> {
     private static final Logger log = LogManager.getLogger(DefaultUploadFeature.class);
@@ -80,28 +74,6 @@ protected Reply transfer(final Write<Reply> write, final Path file, final Local
      * @return Wrapped or same stream
      */
     protected InputStream decorate(final InputStream in, final TransferStatus status, final UploadFilterOptions options) throws BackgroundException {
-        if(options.checksum) {
-            final MessageDigest digest;
-            try {
-                digest = this.digest();
-            }
-            catch(IOException e) {
-                throw new DefaultIOExceptionMappingService().map(e);
-            }
-            if(null != digest) {
-                return new DigestInputStream(in, digest) {
-                    @Override
-                    public void close() throws IOException {
-                        super.close();
-                        status.setChecksum(Checksum.parse(Hex.encodeHexString(digest.digest())));
-                    }
-                };
-            }
-        }
         return in;
     }
-
-    protected MessageDigest digest() throws IOException {
-        return null;
-    }
 }

dropbox/src/main/java/ch/cyberduck/core/dropbox/DropboxUploadFeature.java

@@ -18,21 +18,8 @@
 
 import ch.cyberduck.core.http.HttpUploadFeature;
 
-import java.io.IOException;
-import java.security.MessageDigest;
-import java.security.NoSuchAlgorithmException;
-
 import com.dropbox.core.v2.files.Metadata;
 
 public class DropboxUploadFeature extends HttpUploadFeature<Metadata> {
 
-    @Override
-    protected MessageDigest digest() throws IOException {
-        try {
-            return new DropboxContentHasher(MessageDigest.getInstance("SHA-256"), MessageDigest.getInstance("SHA-256"), 0);
-        }
-        catch(NoSuchAlgorithmException e) {
-            throw new IOException(e.getMessage(), e);
-        }
-    }
 }

googledrive/src/main/java/ch/cyberduck/core/googledrive/DriveUploadFeature.java

@@ -19,19 +19,6 @@
 
 import com.google.api.services.drive.model.File;
 
-import java.io.IOException;
-import java.security.MessageDigest;
-import java.security.NoSuchAlgorithmException;
-
 public class DriveUploadFeature extends HttpUploadFeature<File> {
 
-    @Override
-    protected MessageDigest digest() throws IOException {
-        try {
-            return MessageDigest.getInstance("MD5");
-        }
-        catch(NoSuchAlgorithmException e) {
-            throw new IOException(e.getMessage(), e);
-        }
-    }
 }

openstack/src/main/java/ch/cyberduck/core/openstack/SwiftSmallObjectUploadFeature.java

@@ -19,21 +19,8 @@
 
 import ch.cyberduck.core.http.HttpUploadFeature;
 
-import java.io.IOException;
-import java.security.MessageDigest;
-import java.security.NoSuchAlgorithmException;
-
 import ch.iterate.openstack.swift.model.StorageObject;
 
 public class SwiftSmallObjectUploadFeature extends HttpUploadFeature<StorageObject> {
 
-    @Override
-    protected MessageDigest digest() throws IOException {
-        try {
-            return MessageDigest.getInstance("MD5");
-        }
-        catch(NoSuchAlgorithmException e) {
-            throw new IOException(e.getMessage(), e);
-        }
-    }
 }

s3/src/main/java/ch/cyberduck/core/s3/S3SingleUploadService.java

@@ -37,10 +37,6 @@
 import org.apache.logging.log4j.Logger;
 import org.jets3t.service.model.StorageObject;
 
-import java.io.IOException;
-import java.security.MessageDigest;
-import java.security.NoSuchAlgorithmException;
-
 public class S3SingleUploadService extends HttpUploadFeature<StorageObject> {
     private static final Logger log = LogManager.getLogger(S3SingleUploadService.class);
 
@@ -80,13 +76,4 @@ public StorageObject upload(final Write<StorageObject> write, final Path file, f
         }
     }
 
-    @Override
-    protected MessageDigest digest() throws IOException {
-        try {
-            return MessageDigest.getInstance("MD5");
-        }
-        catch(NoSuchAlgorithmException e) {
-            throw new IOException(e.getMessage(), e);
-        }
-    }
 }