Use opaque pointers for all remaining address space casts

Author: alexbaden

omniscidb/QueryEngine/ArrayIR.cpp

@@ -142,9 +142,8 @@ std::vector<llvm::Value*> CodeGenerator::codegenArrayExpr(
         codegen_traits_desc.local_addr_space_) {
       allocated_target_buffer = ir_builder.CreateAddrSpaceCast(
           allocated_target_buffer,
-          llvm::PointerType::get(
-              allocated_target_buffer->getType()->getPointerElementType(),
-              co.codegen_traits_desc.local_addr_space_),
+          llvm::PointerType::get(cgen_state_->context_,
+                                 co.codegen_traits_desc.local_addr_space_),
           "allocated.target.buffer.cast");
     }
   } else {

omniscidb/QueryEngine/ExtensionsIR.cpp

@@ -346,7 +346,7 @@ llvm::Value* CodeGenerator::codegenFunctionOper(
         codegen_traits_desc.local_addr_space_) {
       buffer_ret = cgen_state_->ir_builder_.CreateAddrSpaceCast(
           buffer_ret,
-          llvm::PointerType::get(buffer_ret->getType()->getPointerElementType(),
+          llvm::PointerType::get(cgen_state_->context_,
                                  codegen_traits_desc.local_addr_space_),
           "buffer.ret.cast");
     }
@@ -411,7 +411,7 @@ CodeGenerator::beginArgsNullcheck(const hdk::ir::FunctionOper* function_oper,
           codegen_traits_desc.local_addr_space_) {
         null_array_alloca = cgen_state_->ir_builder_.CreateAddrSpaceCast(
             null_array_alloca,
-            llvm::PointerType::get(null_array_alloca->getType()->getPointerElementType(),
+            llvm::PointerType::get(cgen_state_->context_,
                                    codegen_traits_desc.local_addr_space_),
             "null.array.alloca.cast");
       }

omniscidb/QueryEngine/IRCodegen.cpp

@@ -1252,7 +1252,7 @@ llvm::Value* Executor::arrayLoopCodegen(const hdk::ir::Expr* array_expr,
       co.codegen_traits_desc.local_addr_space_) {
     array_idx_ptr = cgen_state_->ir_builder_.CreateAddrSpaceCast(
         array_idx_ptr,
-        llvm::PointerType::get(array_idx_ptr->getType()->getPointerElementType(),
+        llvm::PointerType::get(cgen_state_->context_,
                                co.codegen_traits_desc.local_addr_space_),
         "array.idx.ptrcast");
   }

omniscidb/QueryEngine/LoopControlFlow/JoinLoop.cpp

@@ -95,9 +95,7 @@ llvm::BasicBlock* JoinLoop::codegen(
             co.codegen_traits_desc.local_addr_space_) {
           iteration_counter_ptr = builder.CreateAddrSpaceCast(
               iteration_counter_ptr,
-              llvm::PointerType::get(
-                  iteration_counter_ptr->getType()->getPointerElementType(),
-                  co.codegen_traits_desc.local_addr_space_),
+              llvm::PointerType::get(context, co.codegen_traits_desc.local_addr_space_),
               "iteration.counter.ptr.cast");
         }
         llvm::Value* found_an_outer_match_ptr{nullptr};
@@ -109,9 +107,7 @@ llvm::BasicBlock* JoinLoop::codegen(
               co.codegen_traits_desc.local_addr_space_) {
             found_an_outer_match_ptr = builder.CreateAddrSpaceCast(
                 found_an_outer_match_ptr,
-                llvm::PointerType::get(
-                    found_an_outer_match_ptr->getType()->getPointerElementType(),
-                    co.codegen_traits_desc.local_addr_space_),
+                llvm::PointerType::get(context, co.codegen_traits_desc.local_addr_space_),
                 "found.an.outer.match.ptr.cast");
           }
           builder.CreateStore(ll_bool(false, context), found_an_outer_match_ptr);
@@ -121,9 +117,7 @@ llvm::BasicBlock* JoinLoop::codegen(
               co.codegen_traits_desc.local_addr_space_) {
             current_condition_match_ptr = builder.CreateAddrSpaceCast(
                 current_condition_match_ptr,
-                llvm::PointerType::get(
-                    current_condition_match_ptr->getType()->getPointerElementType(),
-                    co.codegen_traits_desc.local_addr_space_),
+                llvm::PointerType::get(context, co.codegen_traits_desc.local_addr_space_),
                 "current.condition.match.ptr.cast");
           }
         }

omniscidb/QueryEngine/NativeCodegen.cpp

@@ -1100,7 +1100,7 @@ void Executor::createErrorCheckControlFlow(
           error_code_arg_val = ir_builder.CreateAddrSpaceCast(
               error_code_arg,
               llvm::PointerType::get(
-                  error_code_arg->getType()->getPointerElementType(),
+                  cgen_state_->context_,
                   record_error_code_func->getArg(1)->getType()->getPointerAddressSpace()),
               "checkflow.error.cast");
         }
@@ -1945,7 +1945,7 @@ bool Executor::compileBody(const RelAlgExecutionUnit& ra_exe_unit,
           co.codegen_traits_desc.local_addr_space_) {
         loop_done = cgen_state_->ir_builder_.CreateAddrSpaceCast(
             loop_done,
-            llvm::PointerType::get(loop_done->getType()->getPointerElementType(),
+            llvm::PointerType::get(cgen_state_->context_,
                                    co.codegen_traits_desc.local_addr_space_),
             "loop.done.cast");
       }

omniscidb/QueryEngine/RowFuncBuilder.cpp

@@ -1160,7 +1160,7 @@ void RowFuncBuilder::codegenEstimator(std::stack<llvm::BasicBlock*>& array_loops
       co.codegen_traits_desc.local_addr_space_) {
     estimator_key_lv = LL_BUILDER.CreateAddrSpaceCast(
         estimator_key_lv,
-        llvm::PointerType::get(estimator_key_lv->getType()->getPointerElementType(),
+        llvm::PointerType::get(executor_->cgen_state_->context_,
                                cgen_traits.getLocalAddrSpace()),
         "estimator.key.lv.cast");
   }