riscv: KVM: Fix SBI TIME error generation

Andrew Jones · avpatel · commit b90148485299 · 2025-02-17T16:28:28.000+05:30
When an invalid function ID of an SBI extension is used we should return not-supported, not invalid-param. Fixes: 5f862df ("RISC-V: KVM: Add v0.1 replacement SBI extensions defined in v0.2") Signed-off-by: Andrew Jones <ajones@ventanamicro.com> Reviewed-by: Anup Patel <anup@brainfault.org> Link: https://lore.kernel.org/r/20250217084506.18763-11-ajones@ventanamicro.com Signed-off-by: Anup Patel <anup@brainfault.org>
diff --git a/arch/riscv/kvm/vcpu_sbi_replace.c b/arch/riscv/kvm/vcpu_sbi_replace.c
@@ -21,7 +21,7 @@ static int kvm_sbi_ext_time_handler(struct kvm_vcpu *vcpu, struct kvm_run *run,
 	u64 next_cycle;
 
 	if (cp->a6 != SBI_EXT_TIME_SET_TIMER) {
-		retdata->err_val = SBI_ERR_INVALID_PARAM;
+		retdata->err_val = SBI_ERR_NOT_SUPPORTED;
 		return 0;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ static int kvm_sbi_ext_time_handler(struct kvm_vcpu vcpu, struct kvm_run run,`
`21`	`21`	`u64 next_cycle;`
`22`	`22`
`23`	`23`	`if (cp->a6 != SBI_EXT_TIME_SET_TIMER) {`
`24`		`- retdata->err_val = SBI_ERR_INVALID_PARAM;`
	`24`	`+ retdata->err_val = SBI_ERR_NOT_SUPPORTED;`
`25`	`25`	`return 0;`
`26`	`26`	`}`
`27`	`27`