Skip to content

Commit b1c9390

Browse files
jonhunteralexandrebelloni
authored andcommitted
Revert "rtc: tps6586x: Fix initial enable_irq/disable_irq balance"
Commit 1502fe0 ("rtc: tps6586x: Fix initial enable_irq/disable_irq balance") breaks the wake-up alarm for the tps6586x. After this commit was added RTC wake ups from suspend stopped working on the Tegra20 Ventana platform. The problem is that this change set the 'irq_en' variable to true prior to calling devm_request_threaded_irq() to indicate that the IRQ is enabled, however, it was over looked that the flag IRQ_NOAUTOEN is already set meaning that the IRQ is not enabled by default. This prevents the IRQ from being enabled as expected. Revert this change to fix this. Fixes: 1502fe0 ("rtc: tps6586x: Fix initial enable_irq/disable_irq balance") Signed-off-by: Jon Hunter <jonathanh@nvidia.com> Link: https://patch.msgid.link/20251031103741.945460-1-jonathanh@nvidia.com Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
1 parent 3a86608 commit b1c9390

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

drivers/rtc/rtc-tps6586x.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -258,7 +258,6 @@ static int tps6586x_rtc_probe(struct platform_device *pdev)
258258

259259
irq_set_status_flags(rtc->irq, IRQ_NOAUTOEN);
260260

261-
rtc->irq_en = true;
262261
ret = devm_request_threaded_irq(&pdev->dev, rtc->irq, NULL,
263262
tps6586x_rtc_irq,
264263
IRQF_ONESHOT,

0 commit comments

Comments
 (0)