Merge tag 'acpi-6.14-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm

torvalds · torvalds · commit 7108b48e9666 · 2025-02-21T09:11:25.000-08:00
Pull ACPI fix from Rafael Wysocki:
 "Fix a memory leak in the ACPI platform_profile driver (Kurt Borja)"

* tag 'acpi-6.14-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm:
  ACPI: platform_profile: Fix memory leak in profile_class_is_visible()
diff --git a/drivers/acpi/platform_profile.c b/drivers/acpi/platform_profile.c
@@ -417,8 +417,14 @@ static int profile_class_registered(struct device *dev, const void *data)
 
 static umode_t profile_class_is_visible(struct kobject *kobj, struct attribute *attr, int idx)
 {
-	if (!class_find_device(&platform_profile_class, NULL, NULL, profile_class_registered))
+	struct device *dev;
+
+	dev = class_find_device(&platform_profile_class, NULL, NULL, profile_class_registered);
+	if (!dev)
 		return 0;
+
+	put_device(dev);
+
 	return attr->mode;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -417,8 +417,14 @@ static int profile_class_registered(struct device dev, const void data)`
`417`	`417`
`418`	`418`	`static umode_t profile_class_is_visible(struct kobject kobj, struct attribute attr, int idx)`
`419`	`419`	`{`
`420`		`- if (!class_find_device(&platform_profile_class, NULL, NULL, profile_class_registered))`
	`420`	`+ struct device *dev;`
	`421`	`+`
	`422`	`+ dev = class_find_device(&platform_profile_class, NULL, NULL, profile_class_registered);`
	`423`	`+ if (!dev)`
`421`	`424`	`return 0;`
	`425`	`+`
	`426`	`+ put_device(dev);`
	`427`	`+`
`422`	`428`	`return attr->mode;`
`423`	`429`	`}`
`424`	`430`